-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signup: deprecate bp_signup_allowed
function
#397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When deprecating a function we are putting it in the file name corresponding to the deprecated version, not the introduction version. Otherwise it would be problématic as we load latest 2 previous major versions deprecated code.
@imath Ops! My mistake. I totally mixed it up there. I'll fix it. 🙏🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this 👍. Feel free to SVN commit it 🍏
Props imath. Closes buddypress/buddypress#397 Fixes #9250 git-svn-id: http://buddypress.svn.wordpress.org/trunk@14073 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9250
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.