Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: deprecate bp_signup_allowed function #397

Closed
wants to merge 5 commits into from

Conversation

renatonascalves
Copy link
Member

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9250


This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.

@renatonascalves renatonascalves self-assigned this Oct 29, 2024
Copy link
Contributor

@imath imath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @renatonascalves

When deprecating a function we are putting it in the file name corresponding to the deprecated version, not the introduction version. Otherwise it would be problématic as we load latest 2 previous major versions deprecated code.

@renatonascalves
Copy link
Member Author

@imath Ops! My mistake. I totally mixed it up there. I'll fix it. 🙏🏽

@renatonascalves renatonascalves requested a review from imath October 30, 2024 11:09
Copy link
Contributor

@imath imath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this 👍. Feel free to SVN commit it 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants