Signup: deprecate bp_signup_allowed function
#397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imath
suggested changes
Oct 30, 2024
Contributor
imath
left a comment
imath
left a comment
There was a problem hiding this comment.
When deprecating a function we are putting it in the file name corresponding to the deprecated version, not the introduction version. Otherwise it would be problématic as we load latest 2 previous major versions deprecated code.
Member
Author
|
@imath Ops! My mistake. I totally mixed it up there. I'll fix it. 🙏🏽 |
imath
approved these changes
Oct 30, 2024
Contributor
imath
left a comment
imath
left a comment
There was a problem hiding this comment.
Looks good, thanks for this 👍. Feel free to SVN commit it 🍏
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Nov 3, 2024
Props imath. Closes buddypress/buddypress#397 Fixes #9250 git-svn-id: http://buddypress.svn.wordpress.org/trunk@14073 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/omt-buddypress-sync
that referenced
this pull request
Nov 2, 2025
Props imath. Closes buddypress/buddypress#397 Fixes #9250 git-svn-id: https://buddypress.svn.wordpress.org/trunk@14073 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/buddypress-sync
that referenced
this pull request
Nov 3, 2025
Props imath. Closes buddypress/buddypress#397 Fixes #9250 git-svn-id: https://buddypress.svn.wordpress.org/trunk@14073 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9250
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.