-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve deleted users messages in the web and REST API #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a patch for BP Nouveau's messages Ajax, you may need it to be sure the Backbone UI outputs consistent infos about deleted users.
Co-authored-by: imath <[email protected]>
Co-authored-by: imath <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've tested it: works great.
Private messages from a deleted user are properly anonymized in both the web and REST API. Props imath, niftythree. Closes buddypress/buddypress#384 Fixes #9160 git-svn-id: http://buddypress.svn.wordpress.org/trunk@14061 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9160
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.