Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deleted users messages in the web and REST API #384

Closed
wants to merge 11 commits into from

Conversation

renatonascalves
Copy link
Member

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9160


This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.

@renatonascalves renatonascalves self-assigned this Oct 11, 2024
@renatonascalves renatonascalves requested a review from imath October 11, 2024 01:43
Copy link
Contributor

@imath imath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a patch for BP Nouveau's messages Ajax, you may need it to be sure the Backbone UI outputs consistent infos about deleted users.

@renatonascalves renatonascalves requested a review from imath October 22, 2024 00:51
Copy link
Contributor

@imath imath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've tested it: works great.

@renatonascalves renatonascalves deleted the feature/9160 branch October 28, 2024 17:42
dcavins pushed a commit to dcavins/buddypress-wp-svn that referenced this pull request Nov 3, 2024
Private messages from a deleted user are properly anonymized in both the web and REST API.

Props imath, niftythree.

Closes buddypress/buddypress#384
Fixes #9160

git-svn-id: http://buddypress.svn.wordpress.org/trunk@14061 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants