Need to update version of wordpress env package #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@renatonascalves @imath could you please review this. |
|
Hi @narenin I just launched the Unit tests, if they give good results I'll commit your PR. |
|
@imath Thanks for review this PR, as I can check now the unit test give good results. |
|
@imath Just a reminder that we don't use |
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Oct 7, 2024
This update fixes an issue while trying to run `npm run wp-env start`, where the `version` attribute is not longer available in docker. Props imath, narenin, and espellcaste. Fixes #9236 Closes buddypress/buddypress#377 git-svn-id: http://buddypress.svn.wordpress.org/trunk@14030 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9236
The version is already removed in
env packageinlatest versionso updating the same version inpackage.jsonWordPress/gutenberg#63099
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.