Create the Official BuddyPress Logo document #361
Conversation
imath
left a comment
imath
left a comment
There was a problem hiding this comment.
Hi @emaralive
First, thank you very much for your work on this PR. You did an amazing job. But as explained into the contributor Docs, writing documentation is done using Markdown, see:
https://github.com/buddypress/buddypress/blob/master/docs/contributor/documentation/README.md#how-to-contribute-to-buddypress-docs
I've added some suggestions, but the tables need more work, so I simply added an example of how I would "convert" it in Markdown tables.
Could you update the logo.md file so that it's written in Markdown?
+ Could you add a link to this logo.md file in the last bullet point of this page?
https://github.com/buddypress/buddypress/tree/master/docs#readme
emaralive
force-pushed
the
5-migrate-official-logos-and-typeface
branch
from
1cf3f25 to
c6ee656
Compare
|
I forced pushed a 2nd commit which has all the changes you requested. I had to resize all the thumbs to fit into the layout. However, there appear to be 2 commits (1st original and 2nd changes requested). Not sure if I need to do something to remove the original commit or is this good enough? |
imath
left a comment
imath
left a comment
There was a problem hiding this comment.
Hi @emaralive
One word, perfect! Thanks a lot for your changes: it's ready to be SVN committed. I'll do it asap.
This page is the migration of this [https://codex.buddypress.org/official-fonts-and-logos/ codex page]. Props emaralive. Closes buddypress/buddypress#361 git-svn-id: http://buddypress.svn.wordpress.org/trunk@14005 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
This page is the migration of this [https://codex.buddypress.org/official-fonts-and-logos/ codex page]. Props emaralive. Closes buddypress/buddypress#361 git-svn-id: https://buddypress.svn.wordpress.org/trunk@14005 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
This page is the migration of this [https://codex.buddypress.org/official-fonts-and-logos/ codex page]. Props emaralive. Closes buddypress/buddypress#361 git-svn-id: https://buddypress.svn.wordpress.org/trunk@14005 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
2 participants
Create the "Official BuddyPress Logo" document.
bp-documentation: buddypress/bp-documentation#5
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.