-
Notifications
You must be signed in to change notification settings - Fork 169
Join private group #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join private group #312
Conversation
imath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vapvarun
Thanks a lot for your PR. I've suggested some changes because I think we should cover each way to join a group as I've described into the Documentation tracker issue buddypress/bp-documentation#195.
We'll need to create a new directory /user/components/groups/ to put this page in, keeping the /user/administration/groups/ for WP Admin Screens.
About screenshots I think we should choose very neutral texts, the name of the group you choose to illustrate explanations looks risky to me.
- Adds a `components` subdirectory to the user handbook to organize documentation resources about BuddyPress components that are not relative to the WP Administration part. - Adds the "Joining Groups" documentation submitted by vapvarun - Update the user handbook’s manifest Props vapvarun Closes buddypress/buddypress#312 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13995 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
- Adds a `components` subdirectory to the user handbook to organize documentation resources about BuddyPress components that are not relative to the WP Administration part. - Adds the "Joining Groups" documentation submitted by vapvarun - Update the user handbook’s manifest Props vapvarun Closes buddypress/buddypress#312 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13995 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
- Adds a `components` subdirectory to the user handbook to organize documentation resources about BuddyPress components that are not relative to the WP Administration part. - Adds the "Joining Groups" documentation submitted by vapvarun - Update the user handbook’s manifest Props vapvarun Closes buddypress/buddypress#312 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13995 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Trac ticket: buddypress/bp-documentation#195
This Pull Request is for code review only. Please keep all other discussions in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.