-
Notifications
You must be signed in to change notification settings - Fork 169
Group types #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group types #297
Conversation
imath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vapvarun
First, thanks a lot for your work. Great job and very nice screenshots.
I'm suggesting some minor edits as well as some removals when I feel it's a bit redundant.
We'll need to create a new folder for Groups WP Admin page and put this page in it 😉
imath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, I missed a duplicate 😮💨
Props vapvarun Closes buddypress/buddypress#297 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13884 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Props vapvarun Closes buddypress/buddypress#297 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13884 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Props vapvarun Closes buddypress/buddypress#297 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13884 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.