Skip to content

Commit c29ede1

Browse files
dmitshurdmitshur
authored
Require Go 1.7 and newer. (google#554)
We need to do this in order to be able to resolve google#526 without unreasonable compromises. That's the minimum version that has context package in standard library, and built-in support for it inside net/http package. Now that Go 1.8 is out, this "current version, plus one back". Bump up the library version in anticipation of breaking API changes in following commits. It makes sense to bump it now because this commit drops support for Go versions 1.4, 1.5 and 1.6, so we can say that version 2 is the latest supported by older Go versions. Helps google#526.
1 parent 328a420 commit c29ede1

3 files changed

Lines changed: 6 additions & 12 deletions

File tree

‎.travis.yml‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
11
sudo: false
22
language: go
33
go:
4-
- 1.5.4
5-
- 1.6.3
6-
- 1.7
7-
- tip
4+
- 1.7.x
5+
- 1.8.x
6+
- master
87
matrix:
9-
include:
10-
- go: 1.4.3
11-
script:
12-
- go get -t -v ./...
13-
- go test -v -race ./...
148
allow_failures:
15-
- go: tip
9+
- go: master
1610
fast_finish: true
1711
install:
1812
- # Do nothing. This is needed to prevent default install action "go get -t -v ./..." from happening here (we want it to happen inside script step).

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ go-github is a Go client library for accessing the [GitHub API][].
77
**Build Status:** [![Build Status](https://travis-ci.org/google/go-github.svg?branch=master)](https://travis-ci.org/google/go-github)
88
**Test Coverage:** [![Test Coverage](https://coveralls.io/repos/google/go-github/badge.svg?branch=master)](https://coveralls.io/r/google/go-github?branch=master) ([gocov report](https://drone.io/github.com/google/go-github/files/coverage.html))
99

10-
go-github requires Go version 1.4 or greater.
10+
go-github requires Go version 1.7 or greater.
1111

1212
## Usage ##
1313

‎github/github.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const (
2929
)
3030

3131
const (
32-
libraryVersion = "2"
32+
libraryVersion = "3"
3333
defaultBaseURL = "https://api.github.com/"
3434
uploadBaseURL = "https://uploads.github.com/"
3535
userAgent = "go-github/" + libraryVersion

0 commit comments

Comments
 (0)