Store before-jump state for switch labels #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to handle the switch statements properly in regards of stack map frames.
Fixes #549
TL;DR
The switch statements are basically jump statements and as such they should store the state (stack + local vars) for all the target labels so the state can be restored once the label is visited.
Unfortunately, I am not able to hand-craft a valid Java source code which would simulate the bytecode generated in CGLIB proxies (that's where the issue was reported originally) and until the test harness is extended to allow testing class transformations on an arbitrary bytecode (eg. not depending on javac output) this particular fix will not have an accompanying test.