Skip to content

wire: increase max witness items per input#1907

Merged
guggero merged 1 commit into
btcsuite:masterfrom
ellemouton:bumpWithnessItemPerInputMax
Nov 1, 2022
Merged

wire: increase max witness items per input#1907
guggero merged 1 commit into
btcsuite:masterfrom
ellemouton:bumpWithnessItemPerInputMax

Conversation

@ellemouton

Copy link
Copy Markdown
Contributor

No description provided.

@guggero guggero linked an issue Nov 1, 2022 that may be closed by this pull request

@guggero guggero left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM 🎉

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3369137304

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.4%) to 74.446%

Files with Coverage Reduction New Missed Lines %
txscript/taproot.go 2 95.93%
peer/peer.go 18 73.2%
Totals Coverage Status
Change from base Build 3325120972: 1.4%
Covered Lines: 12434
Relevant Lines: 16702

💛 - Coveralls

Comment thread wire/msgtx.go
// maxWitnessItemsPerInput is the maximum number of witness items to
// be read for the witness data for a single TxIn. This number is
// derived using a possble lower bound for the encoding of a witness
// derived using a possible lower bound for the encoding of a witness

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example of the "boy/girl scout rule" :D

@guggero guggero merged commit acb7313 into btcsuite:master Nov 1, 2022
fiatjaf added a commit to nbd-wtf/trustedcoin that referenced this pull request Nov 1, 2022
matrix-rider609op added a commit to matrix-rider609op/trustedcoin that referenced this pull request Sep 29, 2025
git-smitmm9 added a commit to git-smitmm9/trustedcoin that referenced this pull request Nov 21, 2025
asheswook pushed a commit to asheswook/btcd that referenced this pull request Apr 2, 2026
…nputMax

wire: increase max witness items per input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consensus conflict caused by maxWitnessItemsPerInput

7 participants