Skip to content

Conversation

@guggero
Copy link
Collaborator

@guggero guggero commented Jul 22, 2020

To run integration tests with btcd on Windows in non-interactive
environments (such as the Travis build with Windows machines), we
need to make sure we can still spawn a child process instead of only a
windows background service.

For this, we add a new command line flag called --nowinservice to disable creating and starting a windows service instead of running a child process.

To run integration tests with btcd on Windows in non-interactive
environments (such as the Travis build with Windows machines), we
need to make sure we can still spawn a child process instead of only a
windows background service.
Copy link
Contributor

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧪

@Roasbeef Roasbeef merged commit 1db1b6f into btcsuite:master Jul 30, 2020
@guggero guggero deleted the disable-windows-service branch July 31, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants