Skip to content

Commit c3a38f7

Browse files
fametranoclaude
andcommitted
Revert "Test Python 3.15 where a beta can say something"
This reverts commit 885a7ca6. The library is not what failed: on 3.15.0b4 the whole suite passes, 77 tests, once cffi is built from source. What failed is cffi's own cp315 wheel, compiled against 3.15b3, whose PyThreadState grew a field in b4 (python/cpython#152448). The offset it was compiled with is now wrong, so the process segfaults in take_gil the moment C re-enters Python through a libffi closure — here the illegal_callback that secp256k1_ec_pubkey_parse invokes on invalid input. Upstream is python-cffi/cffi#263, whose fix is a new cffi release. Keeping the jobs would mean thirteen red ones in every run until 3.15 reaches release candidate, for a cause outside this repository, and a permanently red matrix is one nobody reads. Building cffi from source in CI would hide the red, at the price of a workaround nobody would remember to remove. So 3.15 comes back when there is something to learn from it: cffi wheels that match the interpreter, or the release candidate, which is also when cibuildwheel starts producing a cp315 wheel without a flag and test-static can take 3.15 in the same move. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
1 parent 885a7ca commit c3a38f7

1 file changed

Lines changed: 4 additions & 29 deletions

File tree

‎.github/workflows/main.yml‎

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -214,33 +214,21 @@ jobs:
214214
# the PATH preprocesses the headers for cffi, and what the sdist has to
215215
# carry for it is not what a POSIX build reads
216216
test-sdist:
217-
name: "Test sdist install on ${{ matrix.python-version }}, ${{ matrix.os }}"
217+
name: "Test sdist install on ${{ matrix.os }}"
218218
runs-on: ${{ matrix.os }}
219-
# as in test-dynamic: a beta reports, it does not veto
220-
continue-on-error: ${{ startsWith(matrix.python-version, '3.15') }}
221219
strategy:
222220
fail-fast: false
223221
matrix:
224222
os: [ubuntu-latest, macos-latest, windows-latest]
225-
# 3.14 is the reference interpreter, the one .python-version
226-
# pins for a developer. 3.15 is here because this is the only
227-
# job that compiles the extension against a beta's headers:
228-
# cibuildwheel will not build a cp315 wheel until 3.15 is ABI
229-
# stable, so an API this package uses that 3.15 removed would
230-
# otherwise surface on the day the release candidate lands,
231-
# against a deadline, instead of now
232-
python-version: ["3.14", "3.15"]
233223
needs: build-sdist
234224

235225
steps:
236226
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
237227

238-
- name: Set up Python ${{ matrix.python-version }}
228+
- name: Set up Python
239229
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
240230
with:
241-
python-version: ${{ matrix.python-version }}
242-
# 3.15 has no general availability release to ask for
243-
allow-prereleases: true
231+
python-version: "3.14"
244232

245233
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
246234
with:
@@ -325,9 +313,6 @@ jobs:
325313
test-dynamic:
326314
name: "Test ${{ matrix.python-version }} on ${{ matrix.os }}"
327315
runs-on: ${{ matrix.os }}
328-
# 3.15 is a beta: it is in the matrix to see a break coming, not to
329-
# hold up a merge over an interpreter nobody runs in production yet
330-
continue-on-error: ${{ startsWith(matrix.python-version, '3.15') }}
331316
strategy:
332317
fail-fast: false
333318
matrix:
@@ -348,20 +333,14 @@ jobs:
348333
"3.13",
349334
"3.14",
350335
"3.14t",
351-
"3.15",
352-
"3.15t",
353336
"pypy-3.10",
354337
"pypy-3.11",
355338
]
356339
# 3.14t, the free-threaded interpreter, matters here in particular:
357340
# the dynamic wheel is tagged py3-none, so it is what a
358341
# free-threaded interpreter installs, and unlike the static wheels
359342
# nothing else exercises it (cibuildwheel tests every wheel it
360-
# builds, including cp314t; this job has no such counterpart).
361-
# 3.15 is tested here and nowhere else for the same reason: no
362-
# cp315 wheel exists to test, so py3-none is precisely what pip
363-
# gives an interpreter that new, and what breaks under it breaks
364-
# in the python wrapper rather than in the extension
343+
# builds, including cp314t; this job has no such counterpart)
365344
env:
366345
PYTHON_VERSION: ${{ matrix.python-version }}
367346
OS_NAME: ${{ matrix.os }}
@@ -374,10 +353,6 @@ jobs:
374353
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
375354
with:
376355
python-version: ${{ matrix.python-version }}
377-
# 3.15 has no general availability release to ask for. This
378-
# changes nothing for the rest of the matrix: a version range
379-
# falls back to a prerelease only when no GA one exists
380-
allow-prereleases: true
381356

382357
- name: Upgrade Python packaging tools
383358
run: python -m pip install -U pip pytest

0 commit comments

Comments
 (0)