Using system cert pool#12
Merged
bsphere merged 3 commits intobsphere:masterfrom Sep 8, 2016
caarlos0:certs
Merged
Conversation
|
I'm wondering do we even need to call into the system cert pool? Shouldn't go just use it? |
Contributor
Author
|
@cpuguy83 indeed, it isn't needed. |
Contributor
Author
|
Thanks :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed code to usex509.SystemCertPool().Code now uses the system certificate pool, this way we don't have to dist the certs with the code.
This will only work on Go 1.7+ and is a breaker, so you might want to bump the tags.This change was proposed first here.