Repository navigation
fixed _low_precision to throw the warning when off the table - #4
Merged
Merged
Conversation
|
@kvyh Looks like that didn't quite do it. |
| return self.delta_ut1_utc | ||
| else: | ||
| return self.delta_ut1_utc | ||
| except ValueError: |
Owner
There was a problem hiding this comment.
Why did you change the error type?
Is there any scenario when it goes into the exception part, assuming that now astroplan requires astropy >=1.2?
Author
There was a problem hiding this comment.
I changed the error type because the IndexError was never occuring (which is what got fixed by astropy 1.2), but ValueErrors were caused a lot when it tried to evaluate the iers table.
Author
|
@bsipocz would it be possible to restart the 24.13 check to see if it is working for python2.7? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the error in the
test_iers_download.