Repository navigation
fix(understudy): prune descendant frame ownership and cached frame wrappers on detach and close - #3441
Open
princejain756 wants to merge 1 commit into
Conversation
…appers on detach and close
🦋 Changeset detectedLatest commit: e943c38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closing a page or detaching a frame subtree in BrowserContext left child frame entries in frameOwnerPage and retained cached Frame wrappers, accumulating stale references across repeated page opens and closes (#3240). Process-swap detaches could also remove frames before their replacement session took ownership.
What changed
Test plan
Closes #3240
Summary by cubic
Fixes stale frame ownership and cached Frame wrappers accumulating in
BrowserContextwhen pages close or frame subtrees detach, which piled up across repeated page open/close cycles (#3240). Process-swap detaches now keep frame topology intact until the replacement session takes ownership.FrameRegistryreturns all detached subtree frame IDs, tracks mid-swap frames, and prunes session-owned frames indetachSession.Pageinvalidates WebMCP state, frame cache, and frame ordinals for the whole detached subtree;dispose()clears caches and disposers safely even if an individual disposer throws.BrowserContextsyncs frame ownership during tree seeding, prunes descendant entries fromframeOwnerPageon detach and page destruction, and disposes open pages during context shutdown.Closes #3240.
Written for commit e943c38. Summary will update on new commits.