⚠️ No Changeset found

Latest commit: d3001d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Greptile Summary

Fixes Ollama support by properly detecting when clientOptions contains meaningful configuration data and suppressing unnecessary API key warnings for providers that don't require them.

Key Changes:

• LLMProvider.ts: Changed validation from checking if clientOptions has keys to checking if it has actual non-null/undefined values using Object.values().some(), preventing the function from incorrectly routing to the API-key provider path when all values are undefined
• utils.ts: Added providersWithoutApiKey set containing "ollama" to skip warning logs for providers that intentionally don't require API keys

The root cause was that when using format like ollama/qwen3:1.7b, the code would pass a clientOptions object with undefined values, and the old check (Object.keys(clientOptions).length > 0) would incorrectly return true, attempting to use the non-existent AISDKProvidersWithAPIKey["ollama"] instead of the correct AISDKProviders["ollama"].

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are minimal, well-targeted, and fix a clear bug without introducing new logic complexity. Both fixes address the exact root cause (undefined values being treated as meaningful data), and the implementation is straightforward with no edge cases or side effects.
• No files require special attention

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant User
    participant LLMProvider
    participant getAISDKLanguageModel
    participant AISDKProviders
    participant AISDKProvidersWithAPIKey
    participant loadApiKeyFromEnv
    
    User->>LLMProvider: getClient("ollama/qwen3:1.7b", clientOptions)
    LLMProvider->>getAISDKLanguageModel: call with subProvider="ollama", clientOptions
    
    Note over getAISDKLanguageModel: NEW: Check if clientOptions<br/>has meaningful values
    getAISDKLanguageModel->>getAISDKLanguageModel: Object.values(clientOptions)<br/>.some(v !== undefined)
    
    alt clientOptions has meaningful values
        getAISDKLanguageModel->>AISDKProvidersWithAPIKey: lookup provider with API key
        AISDKProvidersWithAPIKey-->>getAISDKLanguageModel: throw error (ollama not in map)
    else no meaningful values (ollama case)
        getAISDKLanguageModel->>AISDKProviders: lookup default provider
        AISDKProviders-->>getAISDKLanguageModel: return ollama provider
    end
    
    getAISDKLanguageModel-->>LLMProvider: return language model
    
    User->>loadApiKeyFromEnv: load API key for "ollama"
    Note over loadApiKeyFromEnv: NEW: Check if provider<br/>needs API key
    loadApiKeyFromEnv->>loadApiKeyFromEnv: providersWithoutApiKey.has("ollama")
    alt provider needs API key
        loadApiKeyFromEnv->>loadApiKeyFromEnv: log warning if env var not found
    else provider doesn't need API key (ollama)
        loadApiKeyFromEnv->>loadApiKeyFromEnv: skip warning log
    end
    loadApiKeyFromEnv-->>User: return undefined (no error)