Gate release creation on package.json version changes on main, instead of Changesets publishedPackages. #1469

monadoid · 2025-12-23T22:20:58Z

why

Server binaries/releases were skipped because @browserbasehq/stagehand-server is private (not npm-published), so the workflow never detected a “server publish” event.

what changed

Gate server tagging + binary build + GitHub Release creation on packages/server/package.json version changes on main, instead of Changesets publishedPackages.

test plan

See if binaries are build on merge to main

Summary by cubic

Switch server release workflow to trigger on packages/server/package.json version changes on main. This fixes skipped server binaries/releases for the private @browserbasehq/stagehand-server package.

Bug Fixes
- Compare server package version between before/after commits and set a server_release flag.
- Gate tag creation, binary builds, and GitHub Release on server_release.
- Annotate tag to the current SHA and rename outputs from server_published to server_release.
- Add a changeset bump to test the pipeline.

^{Written for commit e224b95. Summary will update automatically on new commits.}

…ges/server/package.json version changes on main, instead of Changesets publishedPackages.

changeset-bot · 2025-12-23T22:21:02Z

🦋 Changeset detected

Latest commit: e224b95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@browserbasehq/stagehand-server	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cubic-dev-ai

No issues found across 2 files

greptile-apps · 2025-12-23T22:23:45Z

Greptile Summary

Changed the server release detection mechanism from relying on Changesets publishedPackages output to directly comparing packages/server/package.json version between commits. This fixes the issue where server binaries weren't built because @browserbasehq/stagehand-server is private and never appears in publishedPackages.

Key changes:

Version detection now uses git show to compare package.json between github.event.before and github.sha
Renamed output from server_published to server_release for clarity
Added explicit target SHA when creating git tags

Issue found:

Logic on line 71-73 will trigger releases when before_version is empty (first push, or if version extraction fails), even if version hasn't changed

Confidence Score: 3/5

This PR solves the immediate problem but has a logic issue that could cause false positive releases
The approach correctly addresses why server binaries weren't being built (private package not in publishedPackages), but the version comparison logic will incorrectly trigger releases when before_version is empty, such as on the first push to main or if the git show command fails for the before commit
Pay close attention to .github/workflows/release.yml line 71-73 - the version comparison logic needs adjustment to prevent false positive releases

Important Files Changed

Filename	Overview
.changeset/soft-days-jump.md	Added changeset for testing binary builds with minor version bump
.github/workflows/release.yml	Changed release detection from Changesets publishedPackages to package.json version diff; potential false positives on first push or when before_version extraction fails

Sequence Diagram

sequenceDiagram
    participant Push as Push to main
    participant Workflow as Release Workflow
    participant Changesets as Changesets Action
    participant Detect as Detect Server Release
    participant Tag as Tag Server Version
    participant Build as Build Binaries
    participant Release as Publish GitHub Release

    Push->>Workflow: Trigger on push
    Note over Workflow: Uses github.event.before<br/>and github.sha
    Workflow->>Changesets: Run changesets action
    Note over Changesets: May create Release PR<br/>or publish packages
    Changesets-->>Workflow: Complete (publishedPackages)
    Workflow->>Detect: Compare package.json versions
    Note over Detect: git show BEFORE_SHA:package.json<br/>vs<br/>git show AFTER_SHA:package.json
    alt Version changed or before_version empty
        Detect-->>Workflow: server_release=true
        Workflow->>Tag: Create git tag
        Tag-->>Workflow: Tag created
        Workflow->>Build: Trigger binary builds
        Build-->>Workflow: Binaries built
        Workflow->>Release: Create GitHub Release
        Release-->>Workflow: Release published
    else No version change
        Detect-->>Workflow: server_release=false
        Note over Workflow: Skip tagging, builds,<br/>and release
    end

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

.github/workflows/release.yml

@tkattkat

monadoid added 2 commits December 23, 2025 14:59

Gate server tagging + binary build + GitHub Release creation on packa…

c8662bb

…ges/server/package.json version changes on main, instead of Changesets publishedPackages.

Bump to test binary builds

9622781

cubic-dev-ai bot reviewed Dec 23, 2025

View reviewed changes

greptile-apps bot reviewed Dec 23, 2025

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

seanmcguire12 approved these changes Dec 23, 2025

View reviewed changes

Resolved edge case for gate in release.yml

e224b95

seanmcguire12 approved these changes Dec 23, 2025

View reviewed changes

monadoid merged commit d634d45 into main Dec 23, 2025
19 checks passed

This was referenced Dec 23, 2025

Version Packages #1414

Merged

Version Packages shaneholloman/stagehand#1

Open

Version Packages CloudEngineHub/stagehand#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Gate release creation on package.json version changes on main, instead of Changesets publishedPackages. #1469

Gate release creation on package.json version changes on main, instead of Changesets publishedPackages. #1469

Uh oh!

monadoid commented Dec 23, 2025 •

edited by cubic-dev-ai bot

Loading

Uh oh!

changeset-bot bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

greptile-apps bot commented Dec 23, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Gate release creation on package.json version changes on main, instead of Changesets publishedPackages. #1469

Gate release creation on package.json version changes on main, instead of Changesets publishedPackages. #1469

Uh oh!

Conversation

monadoid commented Dec 23, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

why

what changed

test plan

Summary by cubic

Uh oh!

changeset-bot bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Dec 23, 2025

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

monadoid commented Dec 23, 2025 •

edited by cubic-dev-ai bot

Loading

changeset-bot bot commented Dec 23, 2025 •

edited

Loading