-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Moved server binary build into release.yaml #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
Greptile SummaryThis PR consolidates server binary building and GitHub Release publishing into the main Key Changes
Architecture ImprovementThe new flow is more robust: it creates tags automatically from the detected version (not relying on external tag pushes) and orchestrates the entire build→publish pipeline within a single workflow triggered by main branch pushes. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Push (main)
participant Release as release job
participant Detect as Detect server publish
participant Tag as Tag creation
participant Build as server_build_binaries job
participant Publish as server_publish_release job
GH->>Release: Push to main triggers
Release->>Release: Run changesets/action
Release->>Detect: Extract version from package.json
Detect->>Detect: Check if server in publishedPackages
Detect-->>Release: Output server_version, server_tag, server_published
Release->>Tag: If server_published == 'true'
Tag->>Tag: Create and push git tag
Release-->>Build: Pass outputs to dependent job
Build->>Build: Run if server_published == 'true'
Build->>Build: Build binaries for all platforms
Build-->>Publish: Upload artifacts
Publish->>Publish: Run if server_published == 'true'
Publish->>Publish: Download artifacts
Publish->>Publish: Create release with assets
|
why
Fix server binaries not publishing because tag pushes from CI didn’t trigger the separate tag-based workflow.
what changed
Move server binary build + GitHub Release publishing into release.yml, gated on Changesets publishing @browserbasehq/stagehand-server.
test plan
See if binaries are published in release (can't test with act)
Summary by cubic
Moved the stagehand/server binary build and GitHub Release into the main release workflow. Fixes missed server binary releases by gating on Changesets publishing of @browserbasehq/stagehand-server.
Bug Fixes
Refactors
Written for commit 180a1c8. Summary will update automatically on new commits.