[test]: add tests for ax tree post-processing #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Architecture diagram
sequenceDiagram
participant Test as Vitest Runner
participant Utils as a11yTree Utils
participant Helper as Helper Functions
Note over Test,Helper: NEW: Unit Test Coverage for Hybrid Snapshot Processing
%% decorateRoles Tests
rect rgb(23,37,84)
Note right of Test: Test Suite: decorateRoles()
Test->>Utils: decorateRoles(nodes, options)
loop For each node
Utils->>Utils: Lookup backendID in tagNameMap
alt Node mapped as Scrollable
Utils->>Utils: NEW TEST: Prepend "scrollable" to role
else Standard Node
Utils->>Utils: Keep original role
end
opt Encoding Error
Utils->>Utils: NEW TEST: Handle encoding fallback
end
end
Utils-->>Test: Decorated Nodes
Test->>Test: Assert roles & labels
end
%% buildHierarchicalTree Tests
rect rgb(23,37,84)
Note right of Test: Test Suite: buildHierarchicalTree()
Test->>Utils: buildHierarchicalTree(nodes)
loop Tree Construction
Utils->>Helper: isStructural(role)
Helper-->>Utils: true/false
alt NEW TEST: Negative Node ID
Utils->>Utils: Skip Node
else NEW TEST: Structural Node (generic/none)
alt No Name & No Children
Utils->>Utils: Prune from tree
else Only Structural Children
Utils->>Utils: Prune & promote descendants
else Valid Content
Utils->>Utils: Remap tag name (e.g. section)
end
else NEW TEST: Role is Combobox/Select
Utils->>Utils: Force role to HTML tag name
end
Utils->>Helper: removeRedundantStaticTextChildren()
alt NEW TEST: Child text == Parent Name
Helper-->>Utils: Remove child
else Text differs
Helper-->>Utils: Keep child
end
end
Utils-->>Test: Final Hierarchical Tree
Test->>Test: Assert structure & pruning
end
%% URL Extraction Tests
rect rgb(23,37,84)
Note right of Test: Test Suite: extractUrlFromAXNode()
Test->>Utils: extractUrlFromAXNode(node)
alt NEW TEST: Valid String Property
Utils-->>Test: Return trimmed URL
else Invalid/Missing
Utils-->>Test: Return undefined
end
end
Contributor
Greptile SummaryAdded comprehensive unit tests for AX tree post-processing utilities to increase test coverage for the hybrid snapshot flow. The tests cover:
All test data is well-structured using helper functions like Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as Test Suite
participant Decorate as decorateRoles()
participant Build as buildHierarchicalTree()
participant Prune as pruneStructuralSafe()
participant Static as removeRedundantStaticTextChildren()
Note over Test: Test Flow for AX Tree Post-Processing
Test->>Decorate: Pass AXNode[] + options
Decorate->>Decorate: Encode backendDOMNodeId
Decorate->>Decorate: Check scrollable/html tags
Decorate->>Decorate: Apply role labels
Decorate-->>Test: Return A11yNode[]
Test->>Build: Pass decorated nodes
Build->>Build: Filter structural nodes without content
Build->>Build: Build parent-child relationships
Build->>Prune: Process each root node
Prune->>Prune: Skip negative nodeIds
Prune->>Prune: Recursively clean children
Prune->>Static: Remove redundant StaticText
Static->>Static: Compare concatenated text to parent
Static-->>Prune: Return filtered children
Prune->>Prune: Apply tag name remapping
Prune-->>Build: Return cleaned node
Build-->>Test: Return hierarchical tree
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
Author
monadoid
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
what changed
added
tests/snapshot-a11y-tree-utils.test.tswhich tests:decorateRoles()#documentnodes get left as 'generic'htmlnodes always get the scrollable labelbuildHierarchicalTree()combobox&selectroles are remapped to their HTML tag namesisStructural()removeRedundantStaticTextChildren()StaticTextchildren when their combined text exactly matches the parent label, keeps them when the text differs, and returns the original array when the parent has no nameextractUrlFromAXNode()test plan
Summary by cubic
Add unit tests for AX tree post-processing helpers to increase coverage of the hybrid snapshot flow (STG-1095). Covers role decoration (scrollable labels, encoding fallback), hierarchical tree building (structural pruning, tag remapping, negative ID skip), structural role detection, redundant StaticText pruning, and URL extraction.
Written for commit 310fd75. Summary will update automatically on new commits.