⚠️ No Changeset found

Latest commit: fbdb1bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Greptile Overview

Greptile Summary

Fixed a bug where the final screenshot was not being captured before the stop() method returned. The ScreenshotCollector.stop() method previously used a fire-and-forget pattern with .catch() for the final screenshot capture, causing it to return before the screenshot was actually captured.

• Changed stop() from synchronous to async (Promise<Buffer[]>)
• Added proper await for final screenshot capture with try/catch error handling
• Updated all 20 eval task files to await the stop() call

Confidence Score: 5/5

• This PR is safe to merge - it's a straightforward async/await fix with proper error handling
• The change is minimal, focused, and correctly fixes the bug. The pattern of making a method async and properly awaiting it is well-established. All call sites have been updated consistently.
• No files require special attention

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant EvalTask
    participant ScreenshotCollector
    participant Page

    EvalTask->>ScreenshotCollector: start()
    loop Every interval
        ScreenshotCollector->>Page: screenshot()
        Page-->>ScreenshotCollector: Buffer
    end
    EvalTask->>ScreenshotCollector: await stop()
    ScreenshotCollector->>ScreenshotCollector: clearInterval()
    ScreenshotCollector->>Page: await screenshot() (final)
    Page-->>ScreenshotCollector: Buffer
    ScreenshotCollector-->>EvalTask: Buffer[]