fix: add `extract()` to `stagehand.history()` #1410

seanmcguire12 · 2025-12-13T00:31:47Z

why

extract() was missing from stagehand.history()
addresses History not including extract #1357

what changed

added a call to addToHistory() after extract() finishes

test plan

Summary by cubic

Include extract() in stagehand.history() so extract actions and results are tracked with instruction, selector, timeout, and schema details.
Fixes missing history entries for extract and addresses #1357.

^{Written for commit 84f95db. Summary will update automatically on new commits.}

changeset-bot · 2025-12-13T00:31:50Z

🦋 Changeset detected

Latest commit: 84f95db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@browserbasehq/stagehand	Patch
@browserbasehq/stagehand-evals	Patch
@browserbasehq/stagehand-server	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

greptile-apps · 2025-12-13T00:34:25Z

Greptile Overview

Greptile Summary

Adds missing extract() call tracking to stagehand.history() by calling addToHistory() after extraction completes, consistent with how act() and observe() methods track history.

Key changes:

Imported toJsonSchema utility for schema serialization
Added addToHistory() call with instruction, selector, timeout, and serialized schema parameters
Correctly uses effectiveSchema (which includes the default schema when none is provided) with proper null checks before calling toJsonSchema()
Fixes issue History not including extract #1357 where extract operations were not appearing in history

The implementation properly handles all extract call variants (with/without instruction, with/without schema, with/without options) and is consistent with existing history tracking patterns.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The fix is straightforward, well-implemented, and addresses both previous review comments. The code correctly handles all edge cases (undefined schemas) with proper null checks, uses the appropriate effectiveSchema variable, and follows the exact same pattern as existing act() and observe() methods. The change is purely additive with no breaking changes.
No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
.changeset/floppy-views-speak.md	5/5	Changeset file correctly documents the patch fix for including `extract()` in history
packages/core/lib/v3/v3.ts	5/5	Added `toJsonSchema` import and `addToHistory()` call after `extract()` completes, correctly handling schema serialization with null checks

Sequence Diagram

sequenceDiagram
    participant User
    participant V3 as Stagehand V3
    participant Handler as ExtractHandler/ApiClient
    participant History as History Array

    User->>V3: extract(instruction, schema?, options?)
    V3->>V3: Normalize arguments
    V3->>V3: Determine effectiveSchema
    Note over V3: effectiveSchema = instruction && !schema<br/>? defaultExtractSchema : schema
    
    alt Using API Client
        V3->>Handler: apiClient.extract()
    else Using Extract Handler
        V3->>Handler: extractHandler.extract()
    end
    
    Handler-->>V3: extraction result
    
    V3->>V3: Convert schema to JSON
    Note over V3: historySchemaDescriptor = effectiveSchema<br/>? toJsonSchema(effectiveSchema) : undefined
    
    V3->>History: addToHistory("extract", params, result)
    Note over History: Records: instruction, selector,<br/>timeout, schema, result
    
    V3-->>User: return result

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

packages/core/lib/v3/v3.ts

cubic-dev-ai

1 issue found across 2 files

Prompt for AI agents (all 1 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/core/lib/v3/v3.ts">

<violation number="1" location="packages/core/lib/v3/v3.ts:1207">
P1: `toJsonSchema(schema)` will throw a runtime error when `schema` is undefined (e.g., when calling `extract(instruction)` without a schema). The function accesses `schema._zod` internally which fails on undefined.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/core/lib/v3/v3.ts

seanmcguire12 · 2025-12-13T01:10:08Z

@greptileai

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

packages/core/lib/v3/v3.ts

seanmcguire12 · 2025-12-13T01:23:56Z

@greptileai

greptile-apps

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

@miguelg719

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @browserbasehq/[email protected] ### Patch Changes - [#1388](#1388) [`605ed6b`](605ed6b) Thanks [@miguelg719](https://github.com/miguelg719)! - Fix multiple click event dispatches on CDP and Anthropic CUA handling (double clicks) - [#1400](#1400) [`34e7e5b`](34e7e5b) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - don't write base64 encoded screenshots to disk when caching agent actions - [#1345](#1345) [`943d2d7`](943d2d7) Thanks [@tkattkat](https://github.com/tkattkat)! - Add support for aborting / stopping an agent run & continuing an agent run using messages from prior runs - [#1334](#1334) [`0e95cd2`](0e95cd2) Thanks [@tkattkat](https://github.com/tkattkat)! - Add support for google vertex provider - [#1410](#1410) [`d4237e4`](d4237e4) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix: include extract in stagehand.history() - [#1315](#1315) [`86975e7`](86975e7) Thanks [@tkattkat](https://github.com/tkattkat)! - Add streaming support to agent through stream:true in the agent config - [#1304](#1304) [`d5e119b`](d5e119b) Thanks [@miguelg719](https://github.com/miguelg719)! - Add support for Microsoft's Fara-7B - [#1346](#1346) [`4e051b2`](4e051b2) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix: don't attach to targets twice - [#1327](#1327) [`6b5a3c9`](6b5a3c9) Thanks [@miguelg719](https://github.com/miguelg719)! - Informed error parsing from api - [#1335](#1335) [`bb85ad9`](bb85ad9) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - add support for page.addInitScript() - [#1331](#1331) [`88d28cc`](88d28cc) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix: page.evaluate() now works with scripts injected via context.addInitScript() - [#1316](#1316) [`45bcef0`](45bcef0) Thanks [@tkattkat](https://github.com/tkattkat)! - Add support for callbacks in stagehand agent - [#1374](#1374) [`6aa9d45`](6aa9d45) Thanks [@miguelg719](https://github.com/miguelg719)! - Fix key action mapping in Anthropic CUA - [#1330](#1330) [`d382084`](d382084) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix: make act, extract, and observe respect user defined timeout param - [#1336](#1336) [`1df08cc`](1df08cc) Thanks [@tkattkat](https://github.com/tkattkat)! - Patch agent on api - [#1358](#1358) [`2b56600`](2b56600) Thanks [@tkattkat](https://github.com/tkattkat)! - Add support for 4.5 opus in cua agent ## @browserbasehq/[email protected] ### Patch Changes - [#1364](#1364) [`ca0630e`](ca0630e) Thanks [@tkattkat](https://github.com/tkattkat)! - Update model handling in agent evals cli - Updated dependencies \[[`605ed6b`](605ed6b), [`34e7e5b`](34e7e5b), [`943d2d7`](943d2d7), [`0e95cd2`](0e95cd2), [`d4237e4`](d4237e4), [`86975e7`](86975e7), [`d5e119b`](d5e119b), [`4e051b2`](4e051b2), [`6b5a3c9`](6b5a3c9), [`bb85ad9`](bb85ad9), [`88d28cc`](88d28cc), [`45bcef0`](45bcef0), [`6aa9d45`](6aa9d45), [`d382084`](d382084), [`1df08cc`](1df08cc), [`2b56600`](2b56600)]: - @browserbasehq/[email protected] ## @browserbasehq/[email protected] ### Patch Changes - Updated dependencies \[[`605ed6b`](605ed6b), [`34e7e5b`](34e7e5b), [`943d2d7`](943d2d7), [`0e95cd2`](0e95cd2), [`d4237e4`](d4237e4), [`86975e7`](86975e7), [`d5e119b`](d5e119b), [`4e051b2`](4e051b2), [`6b5a3c9`](6b5a3c9), [`bb85ad9`](bb85ad9), [`88d28cc`](88d28cc), [`45bcef0`](45bcef0), [`6aa9d45`](6aa9d45), [`d382084`](d382084), [`1df08cc`](1df08cc), [`2b56600`](2b56600)]: - @browserbasehq/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@miguelg719

add extract() to stagehand.history()

eed3619

greptile-apps bot reviewed Dec 13, 2025

View reviewed changes

packages/core/lib/v3/v3.ts Outdated Show resolved Hide resolved

cubic-dev-ai bot reviewed Dec 13, 2025

View reviewed changes

packages/core/lib/v3/v3.ts Outdated Show resolved Hide resolved

check schema if undefined

8f3e8c7

greptile-apps bot reviewed Dec 13, 2025

View reviewed changes

packages/core/lib/v3/v3.ts Outdated Show resolved Hide resolved

use effectiveSchema

84f95db

greptile-apps bot reviewed Dec 13, 2025

View reviewed changes

miguelg719 approved these changes Dec 13, 2025

View reviewed changes

seanmcguire12 merged commit d4237e4 into main Dec 13, 2025
17 checks passed

seanmcguire12 mentioned this pull request Dec 13, 2025

History not including extract #1357

Closed

2 tasks

github-actions bot mentioned this pull request Dec 12, 2025

Version Packages #1305

Merged

coderabbitai bot mentioned this pull request Dec 13, 2025

reverse merge TestsigmaInc/stagehand#12

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add `extract()` to `stagehand.history()` #1410

fix: add `extract()` to `stagehand.history()` #1410

Uh oh!

seanmcguire12 commented Dec 13, 2025 •

edited by cubic-dev-ai bot

Loading

Uh oh!

changeset-bot bot commented Dec 13, 2025 •

edited

Loading

Uh oh!

greptile-apps bot commented Dec 13, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

seanmcguire12 commented Dec 13, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

seanmcguire12 commented Dec 13, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: add extract() to stagehand.history() #1410

fix: add extract() to stagehand.history() #1410

Uh oh!

Conversation

seanmcguire12 commented Dec 13, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

why

what changed

test plan

Summary by cubic

Uh oh!

changeset-bot bot commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

greptile-apps bot commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seanmcguire12 commented Dec 13, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seanmcguire12 commented Dec 13, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: add `extract()` to `stagehand.history()` #1410

fix: add `extract()` to `stagehand.history()` #1410

seanmcguire12 commented Dec 13, 2025 •

edited by cubic-dev-ai bot

Loading

changeset-bot bot commented Dec 13, 2025 •

edited

Loading

greptile-apps bot commented Dec 13, 2025 •

edited

Loading