⚠️ No Changeset found

Latest commit: 08d8454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Greptile Overview

Greptile Summary

Refactors the ActHandler class to centralize LLM action parsing and execution logic, reducing code duplication and improving maintainability.

• Renamed actFromObserveResult to takeDeterministicAction and updated all call sites (ActCache, AgentCache, v3.ts)
• Extracted getActionFromLLM helper that handles inference, metrics recording, normalization, and variable substitution in one place
• Added recordActMetrics to centralize ACT metrics reporting
• Created normalizeActInferenceElement and substituteVariablesInArguments as pure utility functions
• Simplified two-step act flow and self-heal/fallback retry paths to use shared helpers
• Existing behavior is preserved, including selector normalization, variable substitution, and retry logic

Confidence Score: 5/5

• This is a pure refactoring PR with no functional changes - safe to merge
• The changes are purely structural refactoring that centralizes duplicated logic into helper functions. The renamed method takeDeterministicAction is updated at all call sites. The new helper functions (getActionFromLLM, normalizeActInferenceElement, substituteVariablesInArguments) extract existing inline logic without modifying behavior. Variable substitution, selector normalization, metrics reporting, and self-heal retry logic all remain functionally identical to the previous implementation.
• No files require special attention

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant V3 as V3.act()
    participant AH as ActHandler
    participant LLM as getActionFromLLM
    participant TDA as takeDeterministicAction
    participant Page as Page/DOM

    V3->>AH: act(instruction)
    AH->>Page: waitForDomNetworkQuiet()
    AH->>Page: captureHybridSnapshot()
    Page-->>AH: combinedTree, combinedXpathMap
    AH->>LLM: getActionFromLLM(instruction, domElements)
    LLM->>LLM: actInference()
    LLM->>LLM: recordActMetrics()
    LLM->>LLM: normalizeActInferenceElement()
    LLM->>LLM: substituteVariablesInArguments()
    LLM-->>AH: {action, response}
    AH->>TDA: takeDeterministicAction(action)
    TDA->>Page: performUnderstudyMethod()
    
    alt twoStep === true
        AH->>Page: captureHybridSnapshot()
        AH->>AH: diffCombinedTrees()
        AH->>LLM: getActionFromLLM(stepTwoInstructions)
        LLM-->>AH: {secondAction}
        AH->>TDA: takeDeterministicAction(secondAction)
        TDA->>Page: performUnderstudyMethod()
    end

    alt Self-heal on error
        TDA->>Page: captureHybridSnapshot()
        TDA->>LLM: getActionFromLLM(fallback)
        LLM-->>TDA: {fallbackAction}
        TDA->>Page: performUnderstudyMethod(newSelector)
    end

    AH-->>V3: ActResult