Informed error parsing from api #1327

miguelg719 · 2025-12-01T21:12:29Z

Why:

Errors were being wrapped under an opaque stagehand server error. This PR helps provide clearer, actionable errors.

What:

On system events with status=error, throw new Error with the server message.
In the catch block, rethrow non-SyntaxError Errors; only wrap JSON.parse SyntaxError as StagehandResponseParseError.

Test Plan:

Unit test: status=error yields a plain Error with the raw server message.
Unit test: invalid JSON is wrapped as StagehandResponseParseError.

changeset-bot · 2025-12-01T21:12:34Z

🦋 Changeset detected

Latest commit: 360594c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@browserbasehq/stagehand	Patch
@browserbasehq/stagehand-evals	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

greptile-apps · 2025-12-01T21:28:46Z

Greptile Overview

Greptile Summary

Refined SSE error handling in the API client to throw plain Error objects for server errors (matching local SDK behavior) instead of StagehandServerError, and updated catch logic to only wrap SyntaxError from JSON parsing as StagehandResponseParseError.

Changed server error handling to use plain Error for consistency with non-API mode
Refined catch block to distinguish between server errors (re-throw) and JSON parse errors (wrap)

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The changes are focused and logical - switching from custom error class to plain Error for consistency, and refining the catch logic to properly distinguish between server errors and parse errors. The logic correctly handles both scenarios.
No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
packages/core/lib/v3/api.ts	5/5	Changed SSE error handling to throw plain `Error` instead of `StagehandServerError` for server errors, and refined catch logic to only wrap `SyntaxError` as parse errors

Sequence Diagram

sequenceDiagram
    participant Client as API Client
    participant SSE as SSE Stream
    participant Parser as JSON Parser
    participant Handler as Error Handler

    SSE->>Client: SSE event line
    Client->>Parser: JSON.parse(line.slice(6))
    
    alt Valid JSON
        Parser-->>Client: eventData
        
        alt Server Error Event
            Client->>Handler: throw new Error(errorMsg)
            Handler->>Client: Re-throw Error
            Note over Handler: Error && !SyntaxError<br/>→ pass through
        else Finished Event
            Client-->>Client: return result
        else Log Event
            Client->>Client: this.logger(message)
        end
        
    else Invalid JSON (SyntaxError)
        Parser->>Handler: throw SyntaxError
        Handler->>Client: throw StagehandResponseParseError
        Note over Handler: SyntaxError<br/>→ wrap as parse error
    end

greptile-apps

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

packages/core/lib/v3/types/public/apiErrors.ts

cubic-dev-ai

2 issues found across 6 files

Prompt for AI agents (all 2 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/core/tests/api-error-handling.test.ts">

<violation number="1" location="packages/core/tests/api-error-handling.test.ts:6">
P2: The new SSE error test never calls the API error-handling code—it just instantiates a local `Error`, so it cannot fail even if the real SSE handler regresses.</violation>

<violation number="2" location="packages/core/tests/api-error-handling.test.ts:30">
P2: The JSON-parse test only recreates the desired behavior locally instead of calling the real parser, so it provides no regression protection if api.ts stops wrapping `SyntaxError`s.</violation>
</file>

Since this is your first cubic review, here's how it works:

cubic automatically reviews your code and comments on bugs and improvements
Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
Ask questions if you need clarification on any suggestion

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/core/tests/api-error-handling.test.ts

greptile-apps

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

cubic-dev-ai

No issues found across 2 files

@miguelg719

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @browserbasehq/[email protected] ### Patch Changes - [#1388](#1388) [`605ed6b`](605ed6b) Thanks [@miguelg719](https://github.com/miguelg719)! - Fix multiple click event dispatches on CDP and Anthropic CUA handling (double clicks) - [#1400](#1400) [`34e7e5b`](34e7e5b) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - don't write base64 encoded screenshots to disk when caching agent actions - [#1345](#1345) [`943d2d7`](943d2d7) Thanks [@tkattkat](https://github.com/tkattkat)! - Add support for aborting / stopping an agent run & continuing an agent run using messages from prior runs - [#1334](#1334) [`0e95cd2`](0e95cd2) Thanks [@tkattkat](https://github.com/tkattkat)! - Add support for google vertex provider - [#1410](#1410) [`d4237e4`](d4237e4) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix: include extract in stagehand.history() - [#1315](#1315) [`86975e7`](86975e7) Thanks [@tkattkat](https://github.com/tkattkat)! - Add streaming support to agent through stream:true in the agent config - [#1304](#1304) [`d5e119b`](d5e119b) Thanks [@miguelg719](https://github.com/miguelg719)! - Add support for Microsoft's Fara-7B - [#1346](#1346) [`4e051b2`](4e051b2) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix: don't attach to targets twice - [#1327](#1327) [`6b5a3c9`](6b5a3c9) Thanks [@miguelg719](https://github.com/miguelg719)! - Informed error parsing from api - [#1335](#1335) [`bb85ad9`](bb85ad9) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - add support for page.addInitScript() - [#1331](#1331) [`88d28cc`](88d28cc) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix: page.evaluate() now works with scripts injected via context.addInitScript() - [#1316](#1316) [`45bcef0`](45bcef0) Thanks [@tkattkat](https://github.com/tkattkat)! - Add support for callbacks in stagehand agent - [#1374](#1374) [`6aa9d45`](6aa9d45) Thanks [@miguelg719](https://github.com/miguelg719)! - Fix key action mapping in Anthropic CUA - [#1330](#1330) [`d382084`](d382084) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - fix: make act, extract, and observe respect user defined timeout param - [#1336](#1336) [`1df08cc`](1df08cc) Thanks [@tkattkat](https://github.com/tkattkat)! - Patch agent on api - [#1358](#1358) [`2b56600`](2b56600) Thanks [@tkattkat](https://github.com/tkattkat)! - Add support for 4.5 opus in cua agent ## @browserbasehq/[email protected] ### Patch Changes - [#1364](#1364) [`ca0630e`](ca0630e) Thanks [@tkattkat](https://github.com/tkattkat)! - Update model handling in agent evals cli - Updated dependencies \[[`605ed6b`](605ed6b), [`34e7e5b`](34e7e5b), [`943d2d7`](943d2d7), [`0e95cd2`](0e95cd2), [`d4237e4`](d4237e4), [`86975e7`](86975e7), [`d5e119b`](d5e119b), [`4e051b2`](4e051b2), [`6b5a3c9`](6b5a3c9), [`bb85ad9`](bb85ad9), [`88d28cc`](88d28cc), [`45bcef0`](45bcef0), [`6aa9d45`](6aa9d45), [`d382084`](d382084), [`1df08cc`](1df08cc), [`2b56600`](2b56600)]: - @browserbasehq/[email protected] ## @browserbasehq/[email protected] ### Patch Changes - Updated dependencies \[[`605ed6b`](605ed6b), [`34e7e5b`](34e7e5b), [`943d2d7`](943d2d7), [`0e95cd2`](0e95cd2), [`d4237e4`](d4237e4), [`86975e7`](86975e7), [`d5e119b`](d5e119b), [`4e051b2`](4e051b2), [`6b5a3c9`](6b5a3c9), [`bb85ad9`](bb85ad9), [`88d28cc`](88d28cc), [`45bcef0`](45bcef0), [`6aa9d45`](6aa9d45), [`d382084`](d382084), [`1df08cc`](1df08cc), [`2b56600`](2b56600)]: - @browserbasehq/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@miguelg719

Informed error parsing from api

3248a14

miguelg719 marked this pull request as ready for review December 1, 2025 21:25

miguelg719 marked this pull request as draft December 1, 2025 21:25

greptile-apps bot reviewed Dec 1, 2025

View reviewed changes

packages/core/lib/v3/types/public/apiErrors.ts Outdated Show resolved Hide resolved

cubic-dev-ai bot reviewed Dec 1, 2025

View reviewed changes

packages/core/tests/api-error-handling.test.ts Outdated Show resolved Hide resolved

packages/core/tests/api-error-handling.test.ts Outdated Show resolved Hide resolved

miguelg719 added 2 commits December 1, 2025 14:12

address comments

028f9a1

revert v3.ts changes

c0ecc90

miguelg719 marked this pull request as ready for review December 1, 2025 22:14

greptile-apps bot reviewed Dec 1, 2025

View reviewed changes

cubic-dev-ai bot reviewed Dec 1, 2025

View reviewed changes

suppress confusing log

360594c

seanmcguire12 approved these changes Dec 1, 2025

View reviewed changes

miguelg719 merged commit 6b5a3c9 into main Dec 1, 2025
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Informed error parsing from api #1327

Informed error parsing from api #1327

Uh oh!

miguelg719 commented Dec 1, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

greptile-apps bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Informed error parsing from api #1327

Informed error parsing from api #1327

Uh oh!

Conversation

miguelg719 commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why:

What:

Test Plan:

Uh oh!

changeset-bot bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

greptile-apps bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

miguelg719 commented Dec 1, 2025 •

edited

Loading

changeset-bot bot commented Dec 1, 2025 •

edited

Loading

greptile-apps bot commented Dec 1, 2025 •

edited

Loading