Bugfix: error when trying to create empty dir. #998
Conversation
|
|
| if (domElement) nodeData.children.push(domElement); | ||
| } | ||
| } | ||
| // Handle regular elements |
There was a problem hiding this comment.
Why did you move this outside of the else if? - now we do the loop twice
There was a problem hiding this comment.
there're different loops, the first one is for shadow root children and the next one is for regular children.
There was a problem hiding this comment.
I believe open shadow roots can have both normal dom node children and shadow root children, you see this pattern on https://trailhead.salesforce.com/content/learn/modules/starting_force_com/starting_intro?trail_id=force_com_admin_beginner for example. I tested this fix and it works, in fact it was necessary for me to get salesforce automation working, and I included it in my branch 73369f9 (#1114)
If the conversation path doesn't contain any directory path,
save_conversationtries to create an empty directory structure, which raises an error.