Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isContentEditable handling to check readonly and disabled attr… #937

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

guybensimhon1
Copy link
Contributor

Update isContentEditable handling to include input

  • Retrieve tag name and isContentEditable property from element_handle.
  • Check for readonly and disabled attributes before inputting text.

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

…ibutes

- Retrieve tag name and isContentEditable property from element_handle.
- Check for readonly and disabled attributes before inputting text.
- Clear element's textContent regardless of element type.
- Use element_handle.type() with delay for contenteditable or input elements if editable.
- Fallback to element_handle.fill() for non-editable cases.
@MagMueller MagMueller merged commit 262bb26 into browser-use:main Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants