Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works for immo24 #884

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Works for immo24 #884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions browser_use/dom/buildDomTree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,15 +858,23 @@
return null;
}

// Check viewport if needed
// Early viewport check - only filter out elements clearly outside viewport
if (viewportExpansion !== -1) {
const rect = getCachedBoundingRect(node);
if (!rect || (
const style = getCachedComputedStyle(node);

// Skip viewport check for fixed/sticky elements as they may appear anywhere
const isFixedOrSticky = style && (style.position === 'fixed' || style.position === 'sticky');

// Check if element has actual dimensions
const hasSize = node.offsetWidth > 0 || node.offsetHeight > 0;

if (!rect || (!isFixedOrSticky && !hasSize && (
rect.bottom < -viewportExpansion ||
rect.top > window.innerHeight + viewportExpansion ||
rect.right < -viewportExpansion ||
rect.left > window.innerWidth + viewportExpansion
)) {
))) {
if (debugMode) PERF_METRICS.nodeMetrics.skippedNodes++;
return null;
}
Expand Down