Works for immo24 #884
Merged
Works for immo24 #884
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AryamanParida
pushed a commit
to AryamanParida/browser-use
that referenced
this pull request
Mar 7, 2025
…-top Works for immo24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes an update to the
browser_use/dom/buildDomTree.jsfile to improve the viewport check logic for DOM elements. The most important changes include an early viewport check, handling of fixed/sticky elements, and ensuring elements have actual dimensions before applying the viewport check.Improvements to viewport check logic:
browser_use/dom/buildDomTree.js: Added an early viewport check to filter out elements clearly outside the viewport.browser_use/dom/buildDomTree.js: Introduced logic to skip the viewport check for fixed or sticky elements since they may appear anywhere on the page.browser_use/dom/buildDomTree.js: Added a check to ensure elements have actual dimensions (i.e., non-zero width or height) before applying the viewport check.