Fix reddit #866
Merged
Fix reddit #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AryamanParida
pushed a commit
to AryamanParida/browser-use
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
browser_usemodule, focusing on enhancing the functionality for analyzing and debugging webpage structures, especially with respect to handling cookie banners and iframes. The most important changes include adding a new method to get a debug view of the page structure, removing special handling for cookie banners, and adding new test cases.Enhancements to page structure analysis:
browser_use/browser/context.py: Added theget_page_structuremethod to provide a detailed view of the page structure, including handling iframes and skipping certain elements.Removal of special handling for cookie banners:
browser_use/dom/buildDomTree.js: Removed special handling and checks for cookie banners and consent UI elements. [1] [2] [3] [4] [5] [6] [7]New test cases and debugging scripts:
browser_use/dom/tests/debug_page_structure.py: Added a new script to analyze and print the structure of a webpage with enhanced debugging information for cookie consent and fixed position elements.browser_use/dom/tests/extraction_test.py: Updated the test casetest_focus_vs_all_elementsto include additional websites for testing.