Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation: Clarify the Distinction Between browser-use’s Browser and Playwright’s Browser #739

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Update Documentation: Clarify the Distinction Between browser-use’s Browser and Playwright’s Browser #739

merged 2 commits into from
Mar 26, 2025

Conversation

pppp606
Copy link
Contributor

@pppp606 pppp606 commented Feb 16, 2025 •
edited
Loading

While addressing a recent issue, we noticed that some users are confusing browser-use’s Browser class with Playwright’s Browser. I understand that this mix-up is somewhat understandable given the similar naming and usage patterns.

This PR adds a note in the documentation (in the custom functions section) to clearly state that browser-use employs its own for browser control.

@pppp606 pppp606 changed the title Add Browser class note to documentation Clarify the Distinction Between browser-use’s Browser and Playwright’s Browser Feb 16, 2025
@pppp606 pppp606 changed the title Clarify the Distinction Between browser-use’s Browser and Playwright’s Browser Update Documentation: Clarify the Distinction Between browser-use’s Browser and Playwright’s Browser Feb 16, 2025
@pppp606 pppp606 marked this pull request as ready for review February 16, 2025 15:54
@entelligence-ai-reviews
Copy link

Walkthrough

Added a note in custom-functions.mdx clarifying the differences between Browser classes in browser-use and Playwright.

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @bot + *your message*
Example: @bot Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @bot + *feedback*
Example: @bot Do not comment on `save_auth` function !

@bitcoder
Copy link

bitcoder commented Mar 3, 2025

Hi, first for working on this.

  1. Given the PR, it's not still clear to me if we have a direct way or not of obtaining the Browser object from Playwright, given a Browser object from browser-use.
  2. If the previous is not possible at all, what should be the process if we want to access certain things available on Playwright's Browser? Should a issue be raised here to ask to add a similar kind of possibility on the Browser object of browser-use?

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pirate
Update custom-functions.mdx
be399ca 
clarify how to directly access playwright browser object
@pirate
Copy link
Member

pirate commented Mar 26, 2025 •
edited
Loading

@bitcoder I modified the docs to clarify how to access the raw playwright browser object:

# to get the raw playwright browser object from a browser-use Browser obj you can use:
>>> browser.playwright_browser

# or to get it from a BrowserContext object
>>> context.browser.playwright_browser

# and to get the playwright context object
>>> browser.playwright_browser.contexts[0]

@pirate pirate merged commit 8e53532 into browser-use:main Mar 26, 2025
1 check passed
@pirate pirate mentioned this pull request Mar 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirate pirate pirate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pppp606 @entelligence-ai-reviews @bitcoder @CLAassistant @pirate