Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

I tried to generate new tests but there might be some issues in your codebase that I couldn't fix.

🔄 Could not generate any new tests.
🐛 Found 1 bug
🛠️ 0/0 tests passed

🐛 Bug Detection

Potential issues found in the following files:

• browser_use/dom/history_tree_processor/view.py

None.

🛠️ Test Results

All 0 tests passed.

_{Settings | Logs | CodeBeaver}

Hey! Thanks for your effort, but could you revert the formatting changes, it makes it hard to review. You can raise a different PR for format/refactoring changes.

Hi! I'm trying to execute the real browser example (with reasonable modifications) in Firefox:

import os
import sys
from pathlib import Path

from browser_use.agent.views import ActionResult

sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
import asyncio

from langchain_openai import ChatOpenAI

from browser_use import Agent, Controller
from browser_use.browser.browser import Browser, BrowserConfig
from browser_use.browser.context import BrowserContext
from dotenv import load_dotenv
from pydantic import SecretStr

# dotenv
load_dotenv()

api_key = os.getenv('DEEPSEEK_API_KEY', '')
if not api_key:
	raise ValueError('DEEPSEEK_API_KEY is not set')

browser = Browser(
	config=BrowserConfig(
	browser_class='firefox',
		browser_instance_path='C:\\Program Files\\Mozilla Firefox\\firefox.exe',
	)
)


async def main():
	agent = Agent(
		task='In docs.google.com write my Papa a quick letter',
        llm=ChatOpenAI(
			base_url='https://api.deepseek.com/v1',
			model='deepseek-chat',
			api_key=SecretStr(api_key),
		),
		use_vision=False,
		browser=browser,
	)

	await agent.run()
	await browser.close()

	input('Press Enter to close...')


if __name__ == '__main__':
	asyncio.run(main())

However, it gives me the error

future: <Future finished exception=Error('CDP connections are only supported by Chromium')>
playwright._impl._errors.Error: CDP connections are only supported by Chromium

My Firefox version is 128.7.0esr. As far as I know, the CDP connections have been deprecated and turned off at the end of 2024 in Firefox and your code uses CDP connections. Do you have a workaround in mind?

My Firefox version is 128.7.0esr. As far as I know, the CDP connections have been deprecated and turned off at the end of 2024 in Firefox and your code uses CDP connections. Do you have a workaround in mind?

Thanks for the details. I'll test this and think of a solution.

playwright can use webdriver bidi to talk to newer firefox versions, but I'm not sure if the rest of the code fully supports firefox currently. There are a few direct CDP calls.

FYI @alimasri we have merged a different multi-browser-support PR #950

If there is anything you would like to add from this PR that you feel is missing, please rebase and open a new PR. Thank you for your patience and time working on this, we are getting a lot of overlapping PR submissions so we cant just merge them directly, but there are pieces of this PR that are useful and would be great as a new smaller PR.