Cleanup Code #712
Merged
Cleanup Code #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagMueller
reviewed
Feb 13, 2025
| await asyncio.sleep(browser_context.config.wait_between_actions) | ||
| # hash all elements. if it is a subset of cached_state its fine - else break (new elements on page) | ||
|
|
||
| return results |
There was a problem hiding this comment.
I think we should not delete multi_act
| task_message = self.task_instructions(task) | ||
| task_message = HumanMessage( | ||
| content=f'Your ultimate task is: """{task}""". If you achieved your ultimate task, stop everything and use the done action in the next step to complete the task. If not, continue as usual.' | ||
| ) |
There was a problem hiding this comment.
i think we should keep it as a function so that we can call it from outside for new tasks
| from browser_use.browser.context import BrowserContext | ||
|
|
||
| return BrowserContext._enhanced_css_selector_for_element(self) | ||
|
|
There was a problem hiding this comment.
i think we should keep this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up code by removing shallow functions and unused functions from the codebase. I've moved some stateless functions to utility files so that the linter can check whether they are dead code or still used.