Fix redundant <a> tag #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thanks - could you quickly resolve the conflict? |
AryamanParida
pushed a commit
to AryamanParida/browser-use
that referenced
this pull request
Mar 7, 2025
…ant-a-tag Fix redundant <a> tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #640
The issue is that the tags have a single child (the text node) but if the text node is not visible (isTextNodeVisible() returns false) the textnode is returned as null in builDomTree.js and later on when the user prompt is formed, the empty "" is sent to llm. This is increasing the token count and confusing the llm.
I fixed it by adding a check that if tag is and child is null, then don't add the to nodeData in buildDomTree.js
This change won't hamper other cases when has img as child or anything else as child.
before logs
after logs