#544 issue resolved , used chrometabs api #633

SwapnilSonker · 2025-02-08T17:21:20Z

use chrometabs api to group the tabs and altered controller and browser's context.py part

CLAassistant · 2025-02-08T17:21:26Z

All committers have signed the CLA.

codebeaver-ai · 2025-02-08T17:42:31Z

I opened a Pull Request with the following:

🔄 3 tests added.
🐛 No bugs detected in your changes
🛠️ 3/10 tests passed

🔄 Test Updates

I've added 3 tests. They all pass ☑️
New Tests:

tests/test_browser.py
tests/test_context.py
tests/test_views.py

No existing tests required updates.

🐛 Bug Detection

No bugs detected in your changes. Good job!

🛠️ Test Results

3/10 tests passed ⚠️

tests/test_dropdown.py

View error

tests/test_dropdown.py:20: in <module>
    llm = ChatOpenAI(model='gpt-4o')
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_openai/chat_models/base.py:622: in validate_environment
    self.root_client = openai.OpenAI(**client_params, **sync_specific)  # type: ignore[arg-type]
/usr/local/lib/python3.11/site-packages/openai/_client.py:110: in __init__
    raise OpenAIError(
E   openai.OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable

_{tests/test_dropdown.py}

tests/test_dropdown_complex.py

View error

tests/test_dropdown_complex.py:20: in <module>
    llm = ChatOpenAI(model='gpt-4o')
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_openai/chat_models/base.py:622: in validate_environment
    self.root_client = openai.OpenAI(**client_params, **sync_specific)  # type: ignore[arg-type]
/usr/local/lib/python3.11/site-packages/openai/_client.py:110: in __init__
    raise OpenAIError(
E   openai.OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable

_{tests/test_dropdown_complex.py}

tests/test_dropdown_error.py

View error

tests/test_dropdown_error.py:20: in <module>
    llm = ChatOpenAI(model='gpt-4o')
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_openai/chat_models/base.py:622: in validate_environment
    self.root_client = openai.OpenAI(**client_params, **sync_specific)  # type: ignore[arg-type]
/usr/local/lib/python3.11/site-packages/openai/_client.py:110: in __init__
    raise OpenAIError(
E   openai.OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable

_{tests/test_dropdown_error.py}

tests/test_gif_path.py

View error

tests/test_gif_path.py:19: in <module>
    llm = ChatOpenAI(model='gpt-4o')
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_openai/chat_models/base.py:622: in validate_environment
    self.root_client = openai.OpenAI(**client_params, **sync_specific)  # type: ignore[arg-type]
/usr/local/lib/python3.11/site-packages/openai/_client.py:110: in __init__
    raise OpenAIError(
E   openai.OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable

_{tests/test_gif_path.py}

tests/test_models.py

View error

tests/test_models.py:54: in <module>
    ChatOpenAI(
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_openai/chat_models/base.py:622: in validate_environment
    self.root_client = openai.OpenAI(**client_params, **sync_specific)  # type: ignore[arg-type]
/usr/local/lib/python3.11/site-packages/openai/_client.py:110: in __init__
    raise OpenAIError(
E   openai.OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable

_{tests/test_models.py}

tests/test_react_dropdown.py

View error

tests/test_react_dropdown.py:20: in <module>
    llm = ChatOpenAI(model='gpt-4o')
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_openai/chat_models/base.py:622: in validate_environment
    self.root_client = openai.OpenAI(**client_params, **sync_specific)  # type: ignore[arg-type]
/usr/local/lib/python3.11/site-packages/openai/_client.py:110: in __init__
    raise OpenAIError(
E   openai.OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable

_{tests/test_react_dropdown.py}

tests/test_vision.py

View error

tests/test_vision.py:25: in <module>
    llm = ChatOpenAI(model='gpt-4o')
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_openai/chat_models/base.py:622: in validate_environment
    self.root_client = openai.OpenAI(**client_params, **sync_specific)  # type: ignore[arg-type]
/usr/local/lib/python3.11/site-packages/openai/_client.py:110: in __init__
    raise OpenAIError(
E   openai.OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable

_{tests/test_vision.py}

☂️ Coverage Improvements

Coverage improvements by file:

tests/test_browser.py

New coverage: 85.84%
Improvement: +85.84%
tests/test_context.py

New coverage: 34.34%
Improvement: +34.34%
tests/test_views.py

New coverage: 100.00%
Improvement: +100.00%

🎨 Final Touches

I ran the hooks included in the pre-commit config.

_{Settings | Logs | CodeBeaver}

MagMueller · 2025-02-12T03:15:57Z

I think we should not keep this: '--disable-extensions-except=/path/to/your/extension' in the default arguments with this path. You could pass that in as additional arguments.

Could you make it work with an ad blocker, which we could use by default?

MagMueller · 2025-02-12T03:17:43Z

and i think this function is a good custom function, but not for all users

MagMueller · 2025-02-12T06:38:04Z

Okey because if the browser does not open, then retry normally does not help right?

SwapnilSonker · 2025-02-12T06:45:59Z

@MagMueller if the browser does not then the retry does work , if there is any issue i will try this and let you know, yeah we can try for the ad blocker cause it will be a type of mandatory feature to bypass the ad blocker.

MagMueller · 2025-02-12T16:40:54Z

So, you say there are cases where retry works here?

But let's say there is an error; normally, we do the retry in the agent service.py.

MagMueller · 2025-02-12T16:41:27Z

can you make a custom_function example with ungroup / group

SwapnilSonker · 2025-02-13T17:22:21Z

will make and update the PR asap.

SwapnilSonker · 2025-02-14T12:02:24Z

changes have been made @MagMueller review it.

codebeaver-ai · 2025-02-14T12:22:02Z

I tried to generate new tests but there might be some issues in your codebase that I couldn't fix.

🔄 2 test files added.
🐛 Found 2 bugs
🛠️ 2/3 tests passed

🔄 Test Updates

I've added 2 tests. They all pass ☑️
New Tests:

tests/test_prompts.py
tests/test_browser.py

No existing tests required updates.

🐛 Bug Detection

Potential issues found in the following files:

browser_use/agent/service.py

The error is raised when executing an action through the registry’s execute_action method. The mocked async function “test_action_with_browser” expects two arguments (param1 and browser) but when the method calls:

await action.function(**validated_params.model_dump(), **extra_args)
the “browser” argument is not properly passed, so the function call ends up missing the required “browser” parameter. This indicates a bug in the code being tested (specifically, in the registry’s execute_action implementation) rather than an issue with the test itself or its settings.

browser_use/agent/views.py

The error occurs because the code in AgentHistoryList.model_actions() directly attempts to iterate over h.state.interacted_element using zip, but in this test h.state.interacted_element is None. In practical usage, h.state.interacted_element is expected to be an iterable (such as a list), but the test provides None (as defined in the dummy BrowserStateHistory). This causes a TypeError when the code tries to iterate over a NoneType. This is a bug in the code since it does not account for the possibility that the state’s interacted_element might be None.

🛠️ Test Results

2/3 tests passed ⚠️

tests/test_models.py

View error

tests/test_models.py:81: in <module>
    ChatGoogleGenerativeAI(model='gemini-2.0-flash-exp', api_key=api_key_gemini),
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_google_genai/chat_models.py:841: in validate_environment
    self.client = genaix.build_generative_service(
/usr/local/lib/python3.11/site-packages/langchain_google_genai/_genai_extension.py:276: in build_generative_service
    return v1betaGenerativeServiceClient(**config)
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/client.py:667: in __init__
    self._transport = transport_init(
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/transports/grpc.py:235: in __init__
    super().__init__(
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/transports/base.py:100: in __init__
    credentials, _ = google.auth.default(
/usr/local/lib/python3.11/site-packages/google/auth/_default.py:719: in default
    raise exceptions.DefaultCredentialsError(_CLOUD_SDK_MISSING_CREDENTIALS)
E   google.auth.exceptions.DefaultCredentialsError: Your default credentials were not found. To set up Application Default Credentials, see https://cloud.google.com/docs/authentication/external/set-up-adc for more information.

_{tests/test_models.py}

☂️ Coverage Improvements

Coverage improvements by file:

tests/test_prompts.py

New coverage: 100.00%
Improvement: +100.00%
tests/test_browser.py

New coverage: 71.68%
Improvement: +71.68%

🎨 Final Touches

I ran the hooks included in the pre-commit config.

_{Settings | Logs | CodeBeaver}

browser_use/browser/browser.py

browser_use/browser/context.py

browser_use/browser/views.py

browser_use/controller/service.py

browser_use/controller/views.py

codebeaver-ai · 2025-02-15T13:09:11Z

I tried to generate new tests but there might be some issues in your codebase that I couldn't fix.

🔄 3 test files added.
🐛 Found 1 bug
🛠️ 3/4 tests passed

🔄 Test Updates

I've added 3 tests. They all pass ☑️
New Tests:

tests/test_prompts.py
tests/test_browser.py
tests/test_context.py

No existing tests required updates.

🐛 Bug Detection

Potential issues found in the following files:

browser_use/agent/service.py

The error occurs because the registry’s execute_action method (in browser_use/controller/registry/service.py) is not correctly forwarding the extra keyword arguments to the wrapped action function. In this case, the action function test_action_with_browser requires both a “param1” parameter and a “browser” parameter. Although the test calls execute_action with browser=mock_browser, the implementation ends up calling the function without this parameter, causing a TypeError for the missing ‘browser’ argument. This is a bug in the code being tested.

🛠️ Test Results

3/4 tests passed ⚠️

tests/test_models.py

View error

tests/test_models.py:81: in <module>
    ChatGoogleGenerativeAI(model='gemini-2.0-flash-exp', api_key=api_key_gemini),
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_google_genai/chat_models.py:841: in validate_environment
    self.client = genaix.build_generative_service(
/usr/local/lib/python3.11/site-packages/langchain_google_genai/_genai_extension.py:276: in build_generative_service
    return v1betaGenerativeServiceClient(**config)
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/client.py:667: in __init__
    self._transport = transport_init(
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/transports/grpc.py:235: in __init__
    super().__init__(
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/transports/base.py:100: in __init__
    credentials, _ = google.auth.default(
/usr/local/lib/python3.11/site-packages/google/auth/_default.py:719: in default
    raise exceptions.DefaultCredentialsError(_CLOUD_SDK_MISSING_CREDENTIALS)
E   google.auth.exceptions.DefaultCredentialsError: Your default credentials were not found. To set up Application Default Credentials, see https://cloud.google.com/docs/authentication/external/set-up-adc for more information.

_{tests/test_models.py}

☂️ Coverage Improvements

Coverage improvements by file:

tests/test_prompts.py

New coverage: 100.00%
Improvement: +100.00%
tests/test_browser.py

New coverage: 81.42%
Improvement: +81.42%
tests/test_context.py

New coverage: 21.26%
Improvement: +21.26%

🎨 Final Touches

I ran the hooks included in the pre-commit config.

_{Settings | Logs | CodeBeaver}

SwapnilSonker · 2025-02-16T08:15:29Z

@PaperBoardOfficial @MagMueller , review it please.

PaperBoardOfficial · 2025-02-16T15:48:07Z

@SwapnilSonker I have added comment. Please check them. Also, merge conflicts need to be resolved.

SwapnilSonker · 2025-02-19T18:26:44Z

@PaperBoardOfficial fulfilled all the comments , lets close this.

codebeaver-ai · 2025-02-19T18:44:31Z

I opened a Pull Request with the following:

🔄 4 test files added.
🐛 Found 2 bugs
🛠️ 4/5 tests passed

🔄 Test Updates

I've added 4 tests. They all pass ☑️
New Tests:

tests/test_views.py
tests/test_prompts.py
tests/test_browser.py
tests/test_context.py

No existing tests required updates.

🐛 Bug Detection

Potential issues found in the following files:

browser_use/agent/message_manager/service.py

The error occurs during the execution of the action function from the production code (Registry.execute_action), not because the test is written incorrectly. In the failing call for the action “test_action_with_browser”, the action function requires a “browser” parameter. Even though the test passes “browser=mock_browser” in one call, when testing the error case (i.e. calling the action without providing a browser), the production code directly calls the function without any pre-check. As a consequence, Python raises a TypeError for the missing required argument “browser”. The exception is then caught and re-raised as a RuntimeError with an unexpected message. This behavior indicates a bug in the production code: it does not properly detect or handle the missing “browser” argument in a user-friendly way (or with the expected error message), causing the test to fail.

browser_use/agent/service.py

The error occurs because when the registry’s execute_action function is called (with extra keyword arguments such as browser=mock_browser), the registered action function isn’t receiving the extra “browser” argument. In the test, the async function test_action_with_browser expects two arguments (param1 and browser), but it is invoked with only “param1” due to a bug in the code under test (or its mocking/wrapping in the registry) that fails to merge or forward the extra arguments properly. This is not an issue with the way the test is written but indicates a flaw in the implementation of execute_action in the registry service.

🛠️ Test Results

4/5 tests passed ⚠️

tests/test_models.py

View error

tests/test_models.py:81: in <module>
    ChatGoogleGenerativeAI(model='gemini-2.0-flash-exp', api_key=api_key_gemini),
/usr/local/lib/python3.11/site-packages/langchain_core/load/serializable.py:125: in __init__
    super().__init__(*args, **kwargs)
/usr/local/lib/python3.11/site-packages/langchain_google_genai/chat_models.py:841: in validate_environment
    self.client = genaix.build_generative_service(
/usr/local/lib/python3.11/site-packages/langchain_google_genai/_genai_extension.py:276: in build_generative_service
    return v1betaGenerativeServiceClient(**config)
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/client.py:667: in __init__
    self._transport = transport_init(
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/transports/grpc.py:235: in __init__
    super().__init__(
/usr/local/lib/python3.11/site-packages/google/ai/generativelanguage_v1beta/services/generative_service/transports/base.py:100: in __init__
    credentials, _ = google.auth.default(
/usr/local/lib/python3.11/site-packages/google/auth/_default.py:719: in default
    raise exceptions.DefaultCredentialsError(_CLOUD_SDK_MISSING_CREDENTIALS)
E   google.auth.exceptions.DefaultCredentialsError: Your default credentials were not found. To set up Application Default Credentials, see https://cloud.google.com/docs/authentication/external/set-up-adc for more information.

_{tests/test_models.py}

☂️ Coverage Improvements

Coverage improvements by file:

tests/test_views.py

New coverage: 100.00%
Improvement: +100.00%
tests/test_prompts.py

New coverage: 96.49%
Improvement: +96.49%
tests/test_browser.py

New coverage: 85.84%
Improvement: +85.84%
tests/test_context.py

New coverage: 24.90%
Improvement: +24.90%

🎨 Final Touches

I ran the hooks included in the pre-commit config.

_{Settings | Logs | CodeBeaver}

browser-use#544 issue resolved , used chrometabs api

92fe921

codebeaver-ai bot mentioned this pull request Feb 8, 2025

#544 issue resolved , used chrometabs api - Unit Tests #635

Closed

added group/ungroup to custom_functions

cfbb709