Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'NoneType' object has no attribute 'startswith' error (#534) #600

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix 'NoneType' object has no attribute 'startswith' error (#534) #600

merged 1 commit into from
Feb 12, 2025
+9 −6

Conversation

k-w-lee
Copy link
Contributor

@k-w-lee k-w-lee commented Feb 7, 2025

Fixes #534

Description

Refactored _set_model_names to improve readability and fix bugs:

  • Removed redundant assignments and simplified logic.
  • Fixed incorrect attribute check (model_name instead of model in elif block).
  • Initialized self.model_name with "Unknown" upfront.

Changes

  • Consolidated attribute checks for model_name and model.
  • Streamlined logic for setting self.model_name.

Impact

  • Cleaner, more maintainable code with no functional changes.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Lee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MagMueller MagMueller merged commit e60c413 into browser-use:main Feb 12, 2025
1 of 2 checks passed
AryamanParida pushed a commit to AryamanParida/browser-use that referenced this pull request Mar 7, 2025
@MagMueller
Merge pull request browser-use#600 from k-w-lee/fix-none-startswith
d89dbfd 
Fix 'NoneType' object has no attribute 'startswith' error (browser-use#534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'NoneType' object has no attribute 'startswith'
3 participants
@k-w-lee @CLAassistant @MagMueller