fix: ensure save_conversation_path ends with a slash and add tests for conversation logging #570
+86
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r conversation logging
|
|
AryamanParida
pushed a commit
to AryamanParida/browser-use
that referenced
this pull request
Mar 7, 2025
…n_path fix: ensure save_conversation_path ends with a slash and add tests for conversation logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #305
This pull request introduces changes to handle the
save_conversation_pathmore robustly in theAgentclass and adds tests to ensure the functionality works as expected. The most important changes include modifying the initialization of thesave_conversation_pathattribute, updating the documentation to reflect the new behavior, and adding comprehensive tests.Changes to
save_conversation_pathhandling:browser_use/agent/service.py: Added logic to ensure thesave_conversation_pathends with a slash if it is not a file path.Documentation updates:
docs/customize/agent-settings.mdx: Updated the example to use a directory path forsave_conversation_pathinstead of a file path.Added tests:
tests/test_save_conversation.py: Added tests to verify thesave_conversation_pathfunctionality, including cases with and without slashes and deep directory structures.