Fixed allowed_domains restriction feature #1119
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kindly please merge as soon as possible if right, because this feature needed to be integrated in one of my clients Product, Currently its a blocker for us. |
You can still install using your branch. |
HI @SmartManoj , Can you care to elaborate more ? |
|
pirate
approved these changes
Mar 25, 2025
|
thanks for the fix @niranjandasMM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tested the
allowed_domains/restrict_urlsfeature and noticed that when enabling domain restrictions, all domains (including the allowed ones) gets blocked.After debugging, I found that
about:blankwas incorrectly flagged as a non-allowed URL, which prevented navigation.This PR modifies
_is_url_allowedto explicitly allow"about:blank", as it's a common default in browser automation.Let me know if any further adjustments are needed—this fix worked in my case.
Detailed Issue opened: #1120