Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cast element id to string in buildDomTree.js #1081

Merged
merged 1 commit into from
Mar 22, 2025
Merged

fix: cast element id to string in buildDomTree.js #1081

merged 1 commit into from
Mar 22, 2025

Conversation

KazuhitoT
Copy link
Contributor

I encountered an error on a specific webpage due to the element ID not always being a string.
Explicitly casting the element.id to a string resolves the issue.

Error details:

ERROR    [dom] Error evaluating JavaScript: Page.evaluate: TypeError: element.id?.toLowerCase is not a function
    at isInteractiveElement (eval at evaluate (:234:30), <anonymous>:541:19)
    at buildDomTree (eval at evaluate (:234:30), <anonymous>:909:36)
    at buildDomTree (eval at evaluate (:234:30), <anonymous>:971:30)
    at buildDomTree (eval at evaluate (:234:30), <anonymous>:971:30)
    at buildDomTree (eval at evaluate (:234:30), <anonymous>:971:30)
    at buildDomTree (eval at evaluate (:234:30), <anonymous>:971:30)
    at buildDomTree (eval at evaluate (:234:30), <anonymous>:971:30)
    at buildDomTree (eval at evaluate (:234:30), <anonymous>:971:30)
    at buildDomTree (eval at evaluate (:234:30), <anonymous>:816:28)
    at eval (eval at evaluate (:234:30), <anonymous>:999:18)

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MagMueller MagMueller merged commit 15817ee into browser-use:main Mar 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KazuhitoT @CLAassistant @MagMueller