-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devops - Removed hatch #1035
Devops - Removed hatch #1035
Conversation
Hi we use uv to manage dependencies and environments, Hatch might be redundant - what do you think? |
Makes sense. |
@pabshazon We load the buildDomTree.js as a resource in the pip package inside dom/service.py - do we need it for that inside the pip package? |
@MagMueller , imo you do not need hatch nor setuptools as dependencies. Not in runtime, and not in dev. With As I am looking at ✅ I did run a test in my local and is working without hatch nor setuptools deps. Committing it here for you to test - I am still unfamiliar with local env cache for testing. |
I think there might be an issue with the build workflows, in which you need the local dist/file to not exist, I have been using |
✅ Just tested with a fresh .venv and dist and worked well. |
Description
Removed hatch, setuptools, and updated docs
Motivation
Smaller memory footprint, simpler devops workflows, code as documentation