feat!: Use chrome for testing as default#632
Merged
Conversation
3593148 to
a8d0306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces significant changes to improve stability and maintainability by switching to Chrome for Testing as the default browser.
1. Installer Changes on Channel Name Installs
This update replaces previous Chromium builds with the official Chrome for Testing browser on channel name installs. The installation process is simplified by using a standardized Chrome for Testing distribution. The action previously installed the browser to
C:\Program Filesusing the official installer on Windows, or to$RUNNER_TOOL_CACHEon Linux and macOS with the official archive. Now, the action will install the browser to$RUNNER_TOOL_CACHEfrom Chrome for Testing.2. Cache Directory Changes
This update introduces a new cache directory structure for the Chrome for Testing browser. The cache directory is now named
chromeinstead ofchromium.3. Default Version Changes
Previously, the action installed the latest snapshot version. Now, the action will install the stable version of Chrome for Testing by default.
Migration Guide
1. Installer Changes on Channel Name Installs
If you are using the channel name (
stable,beta,dev, orcanary) to install the browser, the new version of the action installs the browser from Chrome for Testing instead of the official installer. Please check if your workflow is using the expected browser binary version with the new version of the action.The installed browser binary with the channel name is as follows:
chromeGoogle Chrome for Testingchrome.exeOn Windows runner, the installed location is changed from
C:\Program Filesto$RUNNER_TOOL_CACHE.2. Cache Directory Changes
If you are self-hosted runner and installing the browser with the channel name to speed up the runner setup, please update your cache directory on your runners. The cache directory has been changed from
chromiumtochromeand ensure that your workflow is using the new cache directory.3. Default Version Changes
If you don't specify
chrome-versionparameter in your workflow, please ensure that your workflow will install the expected version of Chrome for Testing. The default version is the stable channel version of Chrome for Testing instead of the latest version. To install the latest version, you need to specifychrome-version: latestin your workflow.