fix: mock timezone in getTimezoneGMTString test#814
Merged
max246 merged 1 commit intobropat:developfrom Feb 24, 2026
Merged
Conversation
The test hardcoded GMT+00:00 so it only passed on UTC machines. Mock Date.getTimezoneOffset to test UTC, EST, and IST timezones.
nick-pape
force-pushed
the
fix/timezone-test
branch
from
a4a103b to
0ec43d9
Compare
max246
approved these changes
Feb 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTimezoneGMTStringtest hardcodedGMT+00:00, so it only passed on machines set to UTCDate.prototype.getTimezoneOffsetto test three timezones: UTC, EST (UTC-5), and IST (UTC+5:30)Test plan
npx jest src/http/__test__/utils.test.tsxpasses (80/80 tests)🤖 Generated with Claude Code