Merged
Conversation
|
Just installed the new version, no Lock switch available 
|
Collaborator
Author
can you open a new issue, and follow this https://github.com/bropat/eufy-security-client/blob/master/docs/reporting_unknown_devices.md ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is all from @worldjoe but due to lack of communication I couldnt get his PR merged in so I had to rebase into the new code base.
Original owner notes:
Mostly just copy pasta from the T8510P Smart Lock. Not sure how to test this out yet. Sent an invite to control my Eufy (to bropat's gmail) if that helps. 🧑🚒
Fixes #679 #672
Deployment docs didn't make it clear how to test. If anyone can point me at documentation on how to test the changes, either directly or integrated via /fuatakgun/eufy_security that would be great.