Revert "Fix ECDH livestream for E340 doorbell and T8425 floodlight"#790
Revert "Fix ECDH livestream for E340 doorbell and T8425 floodlight"#790
Conversation
|
Revert worked fine! My HomeBase 3 is now back working. |
|
Hi @max246, @danymexi, understand the revert to unblock users. However, I can't see how #779 could break HB3 — every change is device-gated (T8214/T8425 serial checks, isBatteryDoorbellDualE340()/isFloodLightT8425() guards). The only generic code path is the try/catch around RSA in CMD_GATEWAYINFO, but for HB3 RSA should succeed as before and the ECDH fallback is never reached. A few questions to help investigate:
Without an HB3 to test against it's hard to investigate, but happy to help if you can share more details. |
I have a HB3, I can try to debug it, just didnt have time to dig up too much. I had multiple tickets raising the block :( If you want to test yourself, you can run a docker image and HA. It fixes other stuff so I want this PR back in, just dont want to break everything else. |
…ream PR bropat#790 Upstream reverted PR bropat#779 in commit c61c4a1, removing decryptP2PKeyECDH, the RSA-to-ECDH fallback chain, the block-alignment guard, and the ecc_private_key model field. This restores all of those plus the exact byte extraction fix for readNullTerminatedBuffer issues. Co-authored-by: Cursor <[email protected]>
Reverts #779
Seems like 1.9.9 didnt have any issue then from 2.0.0 cant access to HB3. This was the only big PR between 1.9.9 to 2.0.0