Skip to content

Revert "Fix ECDH livestream for E340 doorbell and T8425 floodlight"#790

Merged
max246 merged 1 commit intodevelopfrom
revert-779-feat/e340-doorbell-support
Feb 16, 2026
Merged

Revert "Fix ECDH livestream for E340 doorbell and T8425 floodlight"#790
max246 merged 1 commit intodevelopfrom
revert-779-feat/e340-doorbell-support

Conversation

@max246
Copy link
Copy Markdown
Collaborator

@max246 max246 commented Feb 16, 2026

Reverts #779

Seems like 1.9.9 didnt have any issue then from 2.0.0 cant access to HB3. This was the only big PR between 1.9.9 to 2.0.0

@danymexi
Copy link
Copy Markdown

Revert worked fine! My HomeBase 3 is now back working.

@max246
Copy link
Copy Markdown
Collaborator Author

max246 commented Feb 16, 2026

@lenoxys we need to check more why this is breaking the HB3, but I have double checked with @danymexi and the revert worked.

@max246 max246 merged commit 39e83be into develop Feb 16, 2026
3 checks passed
@max246 max246 mentioned this pull request Feb 16, 2026
@lenoxys
Copy link
Copy Markdown
Contributor

lenoxys commented Feb 16, 2026

Hi @max246, @danymexi, understand the revert to unblock users.

However, I can't see how #779 could break HB3 — every change is device-gated (T8214/T8425 serial checks, isBatteryDoorbellDualE340()/isFloodLightT8425() guards). The only generic code path is the try/catch around RSA in CMD_GATEWAYINFO, but for HB3 RSA should succeed as before and the ECDH fallback is never reached.

A few questions to help investigate:

  • What exactly broke on HB3? Events, livestream, connection, everything?
  • Any logs or error output? Even a snippet would help narrow it down.
  • Was this tested directly with eufy-security-client or through a downstream project (homebridge plugin, HA add-on, etc.)?
  • Is there an issue tracking the HB3 problem?

Without an HB3 to test against it's hard to investigate, but happy to help if you can share more details.

@max246
Copy link
Copy Markdown
Collaborator Author

max246 commented Feb 16, 2026

Hi @max246, @danymexi, understand the revert to unblock users.

However, I can't see how #779 could break HB3 — every change is device-gated (T8214/T8425 serial checks, isBatteryDoorbellDualE340()/isFloodLightT8425() guards). The only generic code path is the try/catch around RSA in CMD_GATEWAYINFO, but for HB3 RSA should succeed as before and the ECDH fallback is never reached.

A few questions to help investigate:

  • What exactly broke on HB3? Events, livestream, connection, everything?
  • Any logs or error output? Even a snippet would help narrow it down.
  • Was this tested directly with eufy-security-client or through a downstream project (homebridge plugin, HA add-on, etc.)?
  • Is there an issue tracking the HB3 problem?

Without an HB3 to test against it's hard to investigate, but happy to help if you can share more details.

I have a HB3, I can try to debug it, just didnt have time to dig up too much. I had multiple tickets raising the block :(
I asked Dany to run this branch on his system and it just worked again.

If you want to test yourself, you can run a docker image and HA. It fixes other stuff so I want this PR back in, just dont want to break everything else.

@lenoxys
Copy link
Copy Markdown
Contributor

lenoxys commented Feb 16, 2026

@max246 Let's work step by step. I've opened #793 with only the device-gated changes (T8214/T8425 registration + livestream routing). No session or encryption changes. Should be safe to merge and verify HB3 is unaffected.

If it passes, we can re-introduce the ECDH/encryption parts separately.

@lenoxys
Copy link
Copy Markdown
Contributor

lenoxys commented Feb 16, 2026

@max246 Second PR opened: #795 — ECDH encryption support, now gated by device serial prefix (T8214/T8425 only). HB3 and all other devices should hit the exact same RSA path as before. Depends on #793.

jaburges added a commit to jaburges/eufy-security-client that referenced this pull request Feb 17, 2026
…ream PR bropat#790

Upstream reverted PR bropat#779 in commit c61c4a1, removing decryptP2PKeyECDH,
the RSA-to-ECDH fallback chain, the block-alignment guard, and the
ecc_private_key model field. This restores all of those plus the exact
byte extraction fix for readNullTerminatedBuffer issues.

Co-authored-by: Cursor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants