Skip to content

Video playback broken on Android 10 arm64 #445

New issue
New issue
Closed
Closed
Video playback broken on Android 10 arm64#445
Labels
upstreambugs which are identified in upstream Chromium

Description

@alex-kinokon
alex-kinokon
opened on Dec 21, 2019

Affected device/platforms

Android OS version CPU GPU disable AImageReader disable hw video decode users
9 64-bit Adreno 540 ✔ ✔ @HigH-HawK
10 64bit Adreno 640 ? ✔ @proteriax @Jaminanim
10 64bit Adreno 540 ? ✔ @kkkrist @l-easwar-akiyama @r3muxd
10 64bit Adreno 630 ? ✔ @ben-page @valpamp
10 64bit ARM Mali-G76 ✔ ✔ @aluo-x
10 64bit Adreno 506 ? ✔ @kyelbek

Bromite version

Version: 79.0.3945.94
Arch: arm64
Android version: 10.0.3
Device model: OnePlus 7

Is this bug about the SystemWebView?

No

Is the bug reproducible with latest version?

Yes

Can the bug be reproduced with corresponding Chromium version?

No

Is the bug a crash?

No

Describe the bug

  1. Video playback is broken on Vimeo and other video websites other than YouTube.
  2. Attempting to play a video on a web page will cause the page to flicker.

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Go to https://vimeo.com/channels/staffpicks/323783503
  2. Click play

Expected behavior

Video starts playing.

Actual behavior

It does not.

Screenshots

Screenshot_20191221-023153

Activity

  1. csagan5 commented on Dec 21, 2019

    @csagan5
    csagan5
    on Dec 21, 2019
    Contributor

    Cannot reproduce this issue. @nikolowry perhaps you can test too?

  2. Outi-s commented on Dec 21, 2019

    @Outi-s
    Outi-s
    on Dec 21, 2019

    Can't reproduce this issue either. Video played fine for me.

  3. csagan5 commented on Dec 21, 2019

    @csagan5
    csagan5
    on Dec 21, 2019
    Contributor

    @subi54 thanks for testing.

    @proteriax any clue in your adb logcat? perhaps your Android OS does not have some codec decoding capability?

  4. kkkrist commented on Dec 21, 2019

    @kkkrist
    kkkrist
    on Dec 21, 2019

    I'm also experiencing this, on Twitter for example. The first couple of frames play (with sound), then the player crashes. On Chrome 79.0.3945.93 the same videos do play without any issues. I'm on a Pixel 2 XL with Android 10 (Dec). Will try to pull a logcat.

  6. csagan5 commented on Dec 21, 2019

    @csagan5
    csagan5
    on Dec 21, 2019
    Contributor

    @kkkrist @Icejr sure, take your time. I might have reproduced it sometimes as well, but over longer periods of playback time.

    I think the issue might have affected v78 as well.

  7. ben-page commented on Dec 21, 2019

    @ben-page
    ben-page
    on Dec 21, 2019

    I'm have this issue for most videos as well. I actually get the Bronite keeps stopping dialog. Although, the Close App button doesn't kill Bromite. It did not happen on the last release. And the sites work in Chrome stable.

    This is from a Rooted, but otherwise stock Pixel 3 XL with Android 10 and the December patch.

    [logcat_12-21-2019_16-10-15.zip]

  8. kkkrist commented on Dec 21, 2019

    @kkkrist
    kkkrist
    on Dec 21, 2019

    Here are some logs:

    [removed]

    This issue wasn't present in v78 on my end, would've noticed for sure I think.

  9. csagan5 commented on Dec 21, 2019

    @csagan5
    csagan5
    on Dec 21, 2019
    Contributor

    The crash found in your logcat:

    [12-21 22:57:27.025 11775:11775 F/DEBUG]*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
[12-21 22:57:27.026 11775:11775 F/DEBUG]Build fingerprint: 'google/taimen/taimen:10/QQ1A.191205.008/5974827:user/release-keys'
[12-21 22:57:27.026 11775:11775 F/DEBUG]Revision: 'rev_10'
[12-21 22:57:27.026 11775:11775 F/DEBUG]ABI: 'arm64'
[12-21 22:57:27.027 11775:11775 F/DEBUG]Timestamp: 2019-12-21 22:57:27+0100
[12-21 22:57:27.027 11775:11775 F/DEBUG]pid: 11707, tid: 11760, name: ImageReader-1x1  >>> org.bromite.bromite:privileged_process0 <<<
[12-21 22:57:27.027 11775:11775 F/DEBUG]uid: 10292
[12-21 22:57:27.027 11775:11775 F/DEBUG]signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x0  0000000000000000  x1  0000000000002df0  x2  0000000000000006  x3  00000070ecefe980
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x4  802322110c49122b  x5  802322110c49122b  x6  802322110c49122b  x7  42606863644c3fff
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x8  00000000000000f0  x9  000000717e9384e0  x10 0000000000000000  x11 0000000000000001
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x12 000000000001ac70  x13 0000000000000002  x14 0000000000000000  x15 0000007180af3020
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x16 000000717ea048c0  x17 000000717e9e2060  x18 00000070a06ca000  x19 00000000000000ac
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x20 0000000000002dbb  x21 00000000000000b2  x22 0000000000002df0  x23 00000000ffffffff
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x24 00000070eceff020  x25 00000070ecefed50  x26 0000007180860138  x27 00000000000fd000
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x28 0000007089252000  x29 00000070ecefea30
[12-21 22:57:27.027 11775:11775 F/DEBUG]    sp  00000070ecefe960  lr  000000717e996170  pc  000000717e9961a0
[12-21 22:57:27.040 11775:11775 F/DEBUG]
backtrace:
[12-21 22:57:27.040 11775:11775 F/DEBUG]      #00 pc 00000000000821a0  /apex/com.android.runtime/lib64/bionic/libc.so (abort+176) (BuildId: b58d049709674405423a8d8de1a37f56)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #01 pc 00000000000186d4  /system/lib64/libmediandk.so (__cfi_check_fail+24) (BuildId: 070ca91395586cffc473ba31eee93910)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #02 pc 000000000001ade4  /system/lib64/libmediandk.so (__cfi_check+7652) (BuildId: 070ca91395586cffc473ba31eee93910)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #03 pc 0000000000046ef4  /apex/com.android.runtime/bin/linker64 (__dl__ZN15CFIShadowWriter7CfiFailEmPvS0_S0_+124) (BuildId: 52561db5295b9b5f246e5c95d06a6b3c)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #04 pc 0000000000001160  /apex/com.android.runtime/lib64/bionic/libdl.so (__cfi_slowpath+64) (BuildId: 12e0c86c59cc11545d28655d0e51c65a)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #05 pc 0000000000029f2c  /system/lib64/libmediandk.so (AImageReader::CallbackHandler::onMessageReceived(android::sp<android::AMessage> const&)+404) (BuildId: 070ca91395586cffc473ba31eee93910)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #06 pc 0000000000016960  /system/lib64/libstagefright_foundation.so (android::AHandler::deliverMessage(android::sp<android::AMessage> const&)+48) (BuildId: c58afc2199618f4e88ce8d6482bcc221)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #07 pc 000000000001a4a4  /system/lib64/libstagefright_foundation.so (android::AMessage::deliver()+100) (BuildId: c58afc2199618f4e88ce8d6482bcc221)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #08 pc 00000000000173cc  /system/lib64/libstagefright_foundation.so (android::ALooper::loop()+564) (BuildId: c58afc2199618f4e88ce8d6482bcc221)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #09 pc 00000000000137c0  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+312) (BuildId: 1a9baf080e66cccc6106194a0c4147f8)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #10 pc 00000000000c1794  /system/lib64/libandroid_runtime.so (android::AndroidRuntime::javaThreadShell(void*)+140) (BuildId: de057b63e21f6c0880ad2d2827b8a843)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #11 pc 00000000000e2364  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+36) (BuildId: b58d049709674405423a8d8de1a37f56)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #12 pc 0000000000083d98  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: b58d049709674405423a8d8de1a37f56)

    It is a stagefright/ImageReader crash, and I think it's already reported upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=977583

    Can the bug be reproduced with corresponding Chromium version?

    No

    @proteriax the bug can most likely be reproduced with Chromium, you could not test with the corresponding version because it was/is not yet released.

  10. csagan5
    closed this as completedon Dec 21, 2019
  11. csagan5
    added
    upstreambugs which are identified in upstream Chromium
    on Dec 21, 2019

  12. csagan5 commented on Dec 21, 2019

    @csagan5
    csagan5
    on Dec 21, 2019
    Contributor

    There is already a patch in Bromite to counteract the buggy AImageReader in Android 10, I will add in next release the additional workaround specified in the upstream issue; please follow the upstream issue for the proper solution.

  13. kkkrist commented on Dec 21, 2019

    @kkkrist
    kkkrist
    on Dec 21, 2019

    Thanks for having looked into it! The Chrome version I mentioned above and which plays videos just fine is indeed 32-bit (came pre-installed and was updated via Play Store), the Bromite version I was using is 64-bit.

  14. csagan5 commented on Dec 21, 2019

    @csagan5
    csagan5
    on Dec 21, 2019
    Contributor

    @kkkrist we use Chromium to verify whether bugs like these are from upstream or from Bromite patches, unfortunately the Chromium version matching to current Bromite version is not available at the moment but will be in the next days.

    If upstream does not test/release/maintain the 64-bit version we might have to drop it too, although there are some advantages in using it.

  15. alex-kinokon commented on Dec 21, 2019

    @alex-kinokon
    alex-kinokon
    on Dec 21, 2019
    Author

    @csagan5 Thank you. I didn’t notice the latest Chromium version does not match.

  16. 132 remaining items

  17. csagan5 commented on Mar 19, 2021

    @csagan5
    csagan5
    on Mar 19, 2021
    Contributor

    Great, thanks; I will enable AImageReader by default on next release.

  18. chirayudesai
    added a commit that references this issue on Jan 19, 2023

    AImageReader CFI crash mitigations

    ed8f2db
  19. calyxos-gerrit
    added 3 commits that reference this issue on Mar 7, 2023

    AImageReader CFI crash mitigations

    9ef6c5e

    AImageReader CFI crash mitigations

    d9e8c68

    AImageReader CFI crash mitigations

    fe30a87
  20. calyxos-gerrit
    added a commit that references this issue on Mar 31, 2023

    AImageReader CFI crash mitigations

    81d85e1
  21. calyxos-gerrit
    added a commit that references this issue on May 1, 2023

    AImageReader CFI crash mitigations

    3c7f37b
  22. calyxos-gerrit
    added 2 commits that reference this issue on May 29, 2023

    AImageReader CFI crash mitigations

    d11a36f

    AImageReader CFI crash mitigations

    b111493
  23. calyxos-gerrit
    added a commit that references this issue on Jul 14, 2023

    AImageReader CFI crash mitigations

    c948cde
  24. calyxos-gerrit
    added a commit that references this issue on Sep 12, 2023

    AImageReader CFI crash mitigations

    1deda42
  25. calyxos-gerrit
    added a commit that references this issue on Oct 11, 2023

    AImageReader CFI crash mitigations

    08b8f72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    upstreambugs which are identified in upstream Chromium

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions