Conversation
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
|
Just confirmed by setting package version to |
| "electron-log": "^4.1.1", | ||
| "extract-zip": "^1.6.7", | ||
| "fs-extra": "^7.0.0", | ||
| "got": "^10.7.0", |
There was a problem hiding this comment.
This is the last minor version before 11.0.0 which, generally, has breaking changes (though I didn't investigate if any applied to our pretty minimal use of this lib). My own use within this PR will also work for 10.6.0, I only bumped it bc it was "free" (no extra work needed) and keeps us a bit more up to date.
jameskerr
left a comment
jameskerr
left a comment
There was a problem hiding this comment.
The linux auto updater now checks the mac url to see if the version is greater than or equal to the app.getVersion(). If so, we present a dialog box with a link to the new release.
Thanks Mason!
| try { | ||
| const currentVersion = app.getVersion() | ||
| if (!semver.valid(currentVersion)) | ||
| throw "Invalid current version format: " + currentVersion |
There was a problem hiding this comment.
Not a blocker. When you throw just a string, the stacktrace and file info are not saved in the error. If you want any of those things, then you can `throw new Error("message"). Some debug tooling takes advantace of the extra meta information provided by the Error instance (chrome devtools, jest tests).
Here is a little more detail.
https://stackoverflow.com/a/57077203/3499804
There was a problem hiding this comment.
Oh this is good to know, thanks!
2 participants
fixes #855
See ^^ ticket for screenshot of current dialog box as well as implementation notes
Signed-off-by: Mason Fish [email protected]