Merged
Conversation
This reverts commit d14fd4d.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
I'm currently testing this branch at commit 0babafa. This is a fairly small thing I noticed during testing. It's not the easiest to trigger, but the attached video and steps below seem to trigger it reliably.
An empty slot is left behind for the deleted tab. This empty slot is filled in as soon as I click another tab. I'm guessing we'd have wanted the tab slots to tighten up as soon as the Session was deleted. Repro.mp4 |
This comment was marked as resolved.
This comment was marked as resolved.
philrz
approved these changes
Aug 15, 2024
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
I've verified the fix of two issues I previously reported on this branch and haven't noticed any new problems, so I'm 👍 on it. @jameskerr and I discussed offline that the "tab bug" described in #3132 (comment) will be addressed in a follow-on PR after this one merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a sessions pane in the left sidebar.
Whenever a new query tab is created, a new entry will be added to the list of sessions. When the tab is closed, the session entry will remain. When the session is clicked, it will either activate the associated tab if it exists, or it will restore that tab, along with it's history. You can right click a session to delete it. Deleting it will destroy the associated tab and history.
The display name of the tab is text of the most recent query in that sessions history.
Fixes #2746
Closes #2467