Conversation
0e43a91 to
10d8974
Compare
philrz
left a comment
There was a problem hiding this comment.
LGTM! 👍
To test, I first confirmed that these changes bring the data load from #3105 back to the ~5 second range on my Macbook. I also reconfirmed that the Zed lake service is still only listening for connections from localhost (#3056). Finally, I started up a loop of the e2e test studied in #3063 and got through 100 successes and 0 failures before I stopped it.
Finally, in anticipation of this merging, I've reopened #3071 because per that issue there's still a possible future where we could dump the node-fetch dependency and have the reliable CI. I've put #3071 in my backlog as a reminder to keep an eye on the Electron releases and when one comes out that ships with a new enough Node version I can re-test then.
Maybe Fixes #3105
Give this a spin @philrz