Merged
Conversation
Contributor
jameskerr
commented
Jun 14, 2024
jameskerr
commented
- Change the Lake type to LakeAttrs
- Rename LakeModel to just Lake
- Convert to Domain Model
- Update lake model usage
- Move lake.ts to src/models
jameskerr
commented
Jun 14, 2024
| get version() { | ||
| return this.attrs.version | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is the I file I changed and moved. Everything else is just updating references and slight usage.
jameskerr
commented
Jun 14, 2024
| } | ||
| }, | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is what the lake.ts model used to look like. Now it looks like the code in the next comment.
philrz
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.