Conversation
philrz
approved these changes
Jun 12, 2024
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
I tested out the branch and it's a functional 👍 for me.
As would be expected, the Cmd+L behavior on macOS worked as Ctrl+L on Linux, so I updated the PR text to reflect that's expected. Also, while the "focus automatically" sounds like what we want, I banged on some older releases and in everything I tried the cursor always landed in the editor as soon as I selected a tab with a Query Session anyway. But if these changes make it extra certain that'll happen a la "belt & suspenders", I'm all about it. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
These changes will improve a few things.
fixes #3093