Zed lake service should listen only on localhost by default#3091
Merged
Conversation
jameskerr
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3056, which has lots of background.
Now that the changes in #3069 have brought us to the the "use Electron's
net.fetch()" state foretold in #3056 (comment), here I'm restoring the prior behavior where the Zed service launched by Zui listens only onlocalhost:9867and therefore will no longer be open to connections from remote hosts.At some point after this merges, I'll introduce something in Settings so a user could open this back up if that's actually their preference (#1105).