Conversation
mattnibs
force-pushed
the
use-describe-endpoint
branch
3 times, most recently
from
4dc17e0 to
9713b4b
Compare
mattnibs
force-pushed
the
use-describe-endpoint
branch
6 times, most recently
from
a659f08 to
b793fe7
Compare
mattnibs
force-pushed
the
use-describe-endpoint
branch
from
b793fe7 to
fe70154
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
This is effectively a note-to-self but I'll record it here in case anyone else has the same question upon reviewing these changes (cc: @jameskerr). In the ztest in brimdata/super#5126 I noticed that the |
mattnibs
force-pushed
the
use-describe-endpoint
branch
2 times, most recently
from
9b7479f to
abc397c
Compare
nwt
reviewed
Jun 3, 2024
philrz
reviewed
Jun 3, 2024
mattnibs
force-pushed
the
use-describe-endpoint
branch
2 times, most recently
from
773b41a to
ae6b433
Compare
This commit uses the Zed service query/describe endpoint to describe to contents of a given Zed query- replacing the use of the compile endpoint and the Zed-ast library for this purpose.
mattnibs
force-pushed
the
use-describe-endpoint
branch
from
ae6b433 to
3b4ce88
Compare
jameskerr
reviewed
Jun 6, 2024
| const {poolName, error} = info | ||
| const pool = this.select(Pools.getByName(lakeId, poolName)) | ||
|
|
||
| if (info.error) { |
jameskerr
reviewed
Jun 6, 2024
| } | ||
|
|
||
| if (!error && history.action === "PUSH") { | ||
| if (history.action === "PUSH") { |
jameskerr
reviewed
Jun 6, 2024
| async compile( | ||
| async describeQuery( | ||
| query: string, | ||
| pool?: string, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit uses the Zed service query/describe endpoint to describe to contents of a given Zed query- replacing the use of the compile endpoint and the Zed-ast library for this purpose.
Fixes #3079