Add Setting for folder to store extracted pcap slices#3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #1423, we've recognized that a user might find it useful to specify a specific directory to hold extracted pcap slices, e.g., if they're gathering them up as part of an investigation. The changes in #3049 made me realize how easy it would be to add this as a Setting, so that's what I've done here.
The attached video shows the feature working as intended using the branch from this PR at commit 651e403. As a baseline I show the default app behavior of extracting to
$TMPDIR. Then I apply the new setting and show the pcap going to the selected directory. Then I clear out the setting and show the pcaps going back to$TMPDIRagain.Demo.mp4
Closes #1423